[Letux-kernel] replacement for omap_hsmmc: hackish try to enable sdio interrupts

Andreas Kemnade andreas at kemnade.info
Fri Aug 31 19:18:06 CEST 2018


On Fri, 31 Aug 2018 17:52:52 +0200
"H. Nikolaus Schaller" <hns at goldelico.com> wrote:

> Hi,
> > Am 31.08.2018 um 17:08 schrieb Andreas Kemnade <andreas at kemnade.info>:
> > 
> > Hi,
> > 
> > I have finally created a better patch for above-mentioned commit, so it can be
> > upstreamed. It works with good performance. After testing on a letux 3704 (so I have both with and without
> > level shifter), I will probably send the patch upstream. It seems te be independant
> > of the other dt things.  
> Looks good. If we have something ready for upstreaming, please do so!
> Just spotted a typo in the commit message:
> s/preperly/properly/
> What I am not sure is about the code style to have blank lines between pinmux entries or have not...
> But DTS maintainers will complain and the compiler will make the same DTB out of it.
well, if it is only that... I could live with both. No blank lines does
not look well, you do not see where the comment belongs. Single line
seems to be accepted, at least in former times, but checkpatch does not
like it.

> > Just one question: is the sdmmc2_dat4.sdmmc2_dir_dat1 setting correct?
> > It differs from u-boot.   
> Hm. Good question. I would guess that kernel DT is correct and u-boot is untested, i.e. may be wrong. AFAIK, no GTA04 uses sdmmc2 in u-boot...
kernel had no mmc2 pinmux (or have I overlooked something?), so it was
relying on uboot to do the job, well lets see how well the pinmux works
with level-shifter in action.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20180831/77dcab9c/attachment.asc>

More information about the Letux-kernel mailing list