[Gta04-owner] gta04 audio patches

Dr. H. Nikolaus Schaller hns at goldelico.com
Sun Sep 4 22:22:20 CEST 2011


Hi John,
many thanks for the patches!

Am 04.09.2011 um 15:57 schrieb John Ogness:

> Hi,
> 
> You will notice from patch 3, that I decided to split the various
> audio devices into their own files. I think this makes it a bit easier
> to maintain. In the case that the hw_params() hook is the same for all
> devices, you may want to add a gta04-core.c file that includes the
> shared hw_params() function, rather than having 4 copies of the same
> function.

That is good.

> I included comments where you may need to write some code. (In
> hw_params() you will for sure need to add code.)
> 
> This should boot with all 4 codecs having their own alsa devices. I
> didn't have time to do much testing, so there may be some typo's
> there. But hopefully it will help you out a bit.
> 
> Please let me know if you have problems with the code.

the patches applied well and I have compiled it without problems.
I have restored gta04-audio.c for the twl4030 driver since it works.

Here is the new boot log:

[   10.807006] Advanced Linux Sound Architecture Driver Version 1.0.21.
[   10.814025] usbcore: registered new interface driver snd-usb-audio
[   10.820617] twl4030_codec_probe
[   10.905029] twl4030_codec_probe ok
[   10.908874] No device for DAI omap-mcbsp-dai-0
[   10.913391] No device for DAI omap-mcbsp-dai-1
[   10.917877] No device for DAI omap-mcbsp-dai-2
[   10.922393] No device for DAI omap-mcbsp-dai-3
[   10.926910] No device for DAI omap-mcbsp-dai-4
[   10.931427] GTA04 OMAP3 SoC snd init
[   10.935302] twl4030_soc_probe
[   10.938354] snd_card_create(0, (null), ...) ok
[   10.943481] asoc: twl4030 <-> omap-mcbsp-dai-0 mapping ok
[   10.949951] twl4030_soc_probe ok
[   10.958190] sound card 0 registered
[   10.962615] gta04-voice SoC init
[   10.966217] gta04-headset SoC init
[   10.969970] gta04-fm SoC init
[   10.973236] ALSA device list:
[   10.976287]   #0: gta04 (twl4030)
[   10.979705] oprofile: using arm/armv7
[   10.983642] TCP cubic registered

The drivers are called and initialized.
But there is still just one sound card in the ALSA device list.

So something is still missing that prevents calls to snd_card_create().

What I have not done is to touch the template code, since e.g. the
GTM601 interface has no controls to present to the user.

Or does the code (indirectly) recognize that there is only empty code in
gta04_voice_hw_params()?

I have pushed all the changes to the git repo although they don't work
completely. This is because working with a local non-public branch
makes it quite difficult to discuss and difficult to follow.

Any ideas?

BR,
Nikolaus


More information about the Gta04-owner mailing list