[Letux-kernel] LetuxOS: Kernel: m-latest 5.7-rc6 successful

[Andreas Kemnade]

On Sun, 7 Jun 2020 18:00:52 +0200
"H. Nikolaus Schaller" <hns at goldelico.com> wrote:

> Hi Andreas,
> 
> > Am 02.06.2020 um 23:07 schrieb H. Nikolaus Schaller <hns at goldelico.com>:
> > 
> >   
> >> Am 02.06.2020 um 22:54 schrieb Stefan Leichter <sle85276 at gmx.de>:
> >> 
> >> Hi Nikolaus,
> >> 
> >> Am 02.06.20 um 09:31 schrieb H. Nikolaus Schaller:  
> >>> Hi Stefan,
> >>>   
> >>>> Am 01.06.2020 um 23:47 schrieb Stefan Leichter <sle85276 at gmx.de>:
> >>>> 
> >>>> not solve the boot hang reliable. Therefore I re-did the git bisect on 5.7-rc7 and
> >>>> booted the kernel up to 10 times before deciding about good or bad.
> >>>> 
> >>>> This brings me to the commit 5bd99ae74ef584bc56895ead2ad070381767ff42 as first
> >>>> bad commit.
> >>>> 
> >>>> Reverting the commit make the kernel 5.7-rc7 boot reliable for me.  
> >>> 
> >>> Can you please try to just disable
> >>> 
> >>> CONFIG_OMAP3_PM_OFFMODE=y
> >>> 
> >>> I have found a note somewhere that this breaks boot on omap3530 on
> >>> the 600MHz Pandora... So it might as well affect the 1GHz Pandora.
> >>> 
> >>> On the other hand the GTA04 devices boot well with any setting.
> >>> 
> >>> So it may be not omap3530 specific but Pandora specific.
> >>> 
> >>> I hope Andreas has an idea why this seems to affect only the OpenPandora.
> >>>   
> >> 
> >> Disabling CONFIG_OMAP3_PM_OFFMODE (in letux-5.7) makes my Pandora boot reliable too.  
> > 
> > Fine!
> > 
> > So we have to find out why it helps and why the GTA04 works well with this
> > defintion.  
> 
> what do you think about making the enable_offmode only for gta04?
> 
> The attached patch should replace your "omap3: give off mode enable a more prominent place".
> 
Hmm, sorry for not taking care earlier.

I think we should follow Tony's suggestion here and match to pmic
compatible (then we also have a chance to upstream it)

BTW:

-	pwrst->next_state = PWRDM_POWER_RET;
+
+	if (enable_off_mode)
+		pwrst->next_state = PWRDM_POWER_RET;
+	else
+		pwrst->next_state = PWRDM_POWER_RET;

That is a no-op.

Regards,
Andreas