[Lenny400] Patches for linux-stable

H. Nikolaus Schaller hns at goldelico.com
Fri Sep 1 19:45:47 CEST 2017

Hi Paul,
great and that quick...

> Am 01.09.2017 um 19:31 schrieb Paul Boddie <paul at boddie.org.uk>:
> Hello,
> I have attached a single, combined diff for all of the changes I have done so 
> far against linux-stable (changeset ef954844c7ace62f773f4f23e28d2d915adc419f).
> There are probably mistakes made in this code, even though it compiles, and so 
> it isn't so interesting to provide the change history because I definitely 
> made mistakes and forgot things as I stumbled through the process of writing 
> it. And the objectives of writing each piece of code are pretty clear, anyway, 
> so there's no benefit in seeing it in "slow motion" with commentary. :-)

No problem. I am currently working on a tool to split commit sets by file name...
So making multiple patches out of this single one isn't very difficult (as
soon as the tool works - which *is* difficult).

> In any case, the logical grouping of the changes is mostly represented by the 
> organisation of the code in the filesystem, with only the board and device 
> tree resources integrating the new and modified functionality. Anything 
> labelled jz4730 or minipc is new functionality; anything labelled jz4740 is 
> modified from existing hardware support.
> Affected files are as follows:
> arch/mips/boot/dts/ingenic/Makefile
> arch/mips/boot/dts/ingenic/jz4730.dtsi
> arch/mips/boot/dts/ingenic/minipc.dts
> (Device tree support, obviously.)
> arch/mips/include/asm/mach-jz4740/base.h
> arch/mips/include/asm/mach-jz4740/irq.h
> arch/mips/include/asm/mach-jz4740/jz4730_timer.h
> arch/mips/include/asm/mach-jz4740/platform.h
> arch/mips/include/asm/mach-jz4740/timer.h
> (Platform support, with separate timer support needing to be added.)
> arch/mips/jz4740/Kconfig
> arch/mips/jz4740/Makefile
> arch/mips/jz4740/board-minipc.c
> arch/mips/jz4740/platform.c
> arch/mips/jz4740/time.c

Here I wonder if we shouldn't have a jz4730 subdirectory?
But if differences are small it may be the better way.

> (Board and platform support.)
> drivers/clk/ingenic/Makefile
> drivers/clk/ingenic/cgu.c
> drivers/clk/ingenic/cgu.h
> drivers/clk/ingenic/jz4730-cgu.c
> include/dt-bindings/clock/jz4730-cgu.h
> (Clock functionality, with modifications to the divider structures because the 
> existing support seemed to write divider values directly into register fields 
> that should contain values encoding a member in a particular sequence of 
> values, noted in the JZ4740 and other programming manuals.)
> drivers/gpio/gpio-ingenic.c
> drivers/irqchip/irq-ingenic.c
> drivers/pinctrl/pinctrl-ingenic.c
> (Addition of pin- and interrupt-related support for the JZ4730.)
> drivers/pwm/Kconfig
> drivers/pwm/Makefile
> drivers/pwm/pwm-jz4730.c
> (A new PWM driver using the PWM peripheral on the JZ4730, based on what the 
> JZ4740 driver was doing.)
> drivers/rtc/Kconfig
> drivers/rtc/rtc-jz4740.c
> (Modifications to the RTC driver, apparently needed.)
> drivers/watchdog/Kconfig
> drivers/watchdog/jz4740_wdt.c
> (Modifications to the watchdog timer, apparently needed.)

Everything looks marvelous!

> I will keep looking at the other areas that will need updating, but I thought 
> that it might be useful to get some feedback now.

I will try to apply/merge it to the Letux tree.
At the moment I am trying to get my cross-compiler working. It stumbles about not
finding some sgidefs.h and byteswap.h. The typical include path problems :)

BR and thanks,

> Paul
> <jz4730-minipc-linux-stable-ef954844c7ace62f.diff>_______________________________________________
> Lenny400 mailing list
> Lenny400 at goldelico.com
> http://lists.goldelico.com/mailman/listinfo.cgi/lenny400

More information about the Lenny400 mailing list