[Lenny400] Patches for linux-stable
H. Nikolaus Schaller
hns at goldelico.com
Fri Sep 1 19:45:47 CEST 2017
great and that quick...
> Am 01.09.2017 um 19:31 schrieb Paul Boddie <paul at boddie.org.uk>:
> I have attached a single, combined diff for all of the changes I have done so
> far against linux-stable (changeset ef954844c7ace62f773f4f23e28d2d915adc419f).
> There are probably mistakes made in this code, even though it compiles, and so
> it isn't so interesting to provide the change history because I definitely
> made mistakes and forgot things as I stumbled through the process of writing
> it. And the objectives of writing each piece of code are pretty clear, anyway,
> so there's no benefit in seeing it in "slow motion" with commentary. :-)
No problem. I am currently working on a tool to split commit sets by file name...
So making multiple patches out of this single one isn't very difficult (as
soon as the tool works - which *is* difficult).
> In any case, the logical grouping of the changes is mostly represented by the
> organisation of the code in the filesystem, with only the board and device
> tree resources integrating the new and modified functionality. Anything
> labelled jz4730 or minipc is new functionality; anything labelled jz4740 is
> modified from existing hardware support.
> Affected files are as follows:
> (Device tree support, obviously.)
> (Platform support, with separate timer support needing to be added.)
Here I wonder if we shouldn't have a jz4730 subdirectory?
But if differences are small it may be the better way.
> (Board and platform support.)
> (Clock functionality, with modifications to the divider structures because the
> existing support seemed to write divider values directly into register fields
> that should contain values encoding a member in a particular sequence of
> values, noted in the JZ4740 and other programming manuals.)
> (Addition of pin- and interrupt-related support for the JZ4730.)
> (A new PWM driver using the PWM peripheral on the JZ4730, based on what the
> JZ4740 driver was doing.)
> (Modifications to the RTC driver, apparently needed.)
> (Modifications to the watchdog timer, apparently needed.)
Everything looks marvelous!
> I will keep looking at the other areas that will need updating, but I thought
> that it might be useful to get some feedback now.
I will try to apply/merge it to the Letux tree.
At the moment I am trying to get my cross-compiler working. It stumbles about not
finding some sgidefs.h and byteswap.h. The typical include path problems :)
BR and thanks,
> Lenny400 mailing list
> Lenny400 at goldelico.com
More information about the Lenny400