[Gta04-owner] [PATCH 1/2] leds/tca6507: Add support for devicetree.

Flemming Richter Mikkelsen quatrox at gmail.com
Thu Oct 18 22:01:02 CEST 2012


On Oct 18, 2012 9:29 PM, "Belisko Marek" <marek.belisko at gmail.com> wrote:
>
> On Thu, Oct 18, 2012 at 6:22 PM, Flemming Richter Mikkelsen
> <quatrox at gmail.com> wrote:
> > Sorry for maybe a stupid question, but is this a bug:
> > +       struct device_node *np = client->dev.of_node, *child;
> >
> > I expected it to be:
> > +       struct device_node *np = { client->dev.of_node, *child };
> >
> > but did not check the types because I don't have access to my computer
atm.
> >
> > If I am not mistaking, the statement:
> > +       struct device_node *np = client->dev.of_node, *child;
> >
> > is the same as:
> > +       struct device_node *np = *child;
> Nope you're wrong.
> It could be written also that way:
> struct device_node *np = client->dev.of_node;
> struct device_node *child;
> but IMO original is OK.

Thank you for explaining. I actually asked a friend since I didn't have my
computer there to check it with.
I agree with you that the original way looks nice, now that I know how it
works:)
It also makes more sense the way you explained it! Good to see I learn
something.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.goldelico.com/pipermail/gta04-owner/attachments/20121018/793b6e6d/attachment-0001.html>


More information about the Gta04-owner mailing list