[Gta04-owner] [PATCH 1/2] leds/tca6507: Add support for devicetree.

Belisko Marek marek.belisko at gmail.com
Thu Oct 18 21:29:19 CEST 2012


On Thu, Oct 18, 2012 at 6:22 PM, Flemming Richter Mikkelsen
<quatrox at gmail.com> wrote:
> Sorry for maybe a stupid question, but is this a bug:
> +       struct device_node *np = client->dev.of_node, *child;
>
> I expected it to be:
> +       struct device_node *np = { client->dev.of_node, *child };
>
> but did not check the types because I don't have access to my computer atm.
>
> If I am not mistaking, the statement:
> +       struct device_node *np = client->dev.of_node, *child;
>
> is the same as:
> +       struct device_node *np = *child;
Nope you're wrong.
It could be written also that way:
struct device_node *np = client->dev.of_node;
struct device_node *child;
but IMO original is OK.
>
> unless client->dev.of_node is a macro.
>
> I didn't double check this, so I might be wrong and only generating noise here.
> _______________________________________________
> Gta04-owner mailing list
> Gta04-owner at goldelico.com
> http://lists.goldelico.com/mailman/listinfo/gta04-owner

Cheers,

mbe

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com


More information about the Gta04-owner mailing list