[Openpvrsgx-devgroup] [PATCH 2/2] pvrsrv: 1.17: osfunc: Add va_to_pfn()

[H. Nikolaus Schaller]

Hi Tony,

> Am 15.11.2023 um 21:45 schrieb H. Nikolaus Schaller <hns at goldelico.com>:
> 
> Hi Tony,
> Thanks for the patches.
> 
> It looks as if my own updates for v6.5 and v6.6 have not reached the github server. And v6.7 is coming soon.
> 
> I'll check if these patches are equivalent to what is already there or if yours add a detail I have been missing.
> 
> BR and thanks,
> Nikolaus
> 
> https://git.goldelico.com/?p=letux-kernel.git;a=blobdiff;f=drivers/gpu/drm/pvrsgx/1.17.4948957/eurasia_km/services4/srvkm/env/linux/osfunc.c;h=a02fac38645218917c6dc6742abcc8875d810ef0;hp=c6c1b1f43155cc940df26e62833df2486e6d1a38;hb=25d3d044b9c87a4ddd67180969aea41d1eea2b29;hpb=c06b0c209743a2daba1d216efcbbcf79c146b786
> 
> https://git.goldelico.com/?p=letux-kernel.git;a=blobdiff;f=mm/pgtable-generic.c;h=bd1a38b28118c91a5f6099e99707d7345dc4aa4c;hp=4fcd959dcc4d02367d06fd06079d5c4ee0fe4f43;hb=ffce891243c9a3b298d1a34e4c8c558d4e8a729d;hpb=25d3d044b9c87a4ddd67180969aea41d1eea2b29
> 
>> Am 15.11.2023 um 08:07 schrieb Tony Lindgren <tony at atomide.com>:
>> 
>> * Tony Lindgren <tony at atomide.com> [231115 07:01]:
>>> With commit 0d940a9b270b ("mm/pgtable: allow pte_offset_map[_lock]() to
>>> fail"), __pte_offset_map_lock() is no longer inlined and not exported
>>> and using it in loadable modules fails.
>>> 
>>> Let's add va_to_pfn() similar to follow_pfn() and drop the pvr specific
>>> function.
>> 
>> This is only briefly tested, I may have missed something so please review.
>> 
>> Regards,
>> 
>> Tony
> 

finally, I have checked the status of these patches.

Indeed, a functionally equivalent patch for 1/2 is already included.

For 2/2 I have reworked your patch to be guarded by #if (LINUX_VERSION_CODE < KERNEL_VERSION(6,6,0))
and this meant renaming the function and parameters back to non-kernel code style...

Well, one may argue that nobody will take this patch and backport to older kernels, but
who knows.

What should be done by someone with a lot of spare time is to open a fork/branch of the
feature patches sitting on top of linus/master and resolve all these dependencies for
e.g. v6.7-rc kernels. I.e. make the source code get rid of all such kernel version dependencies.
But it is a big project...

This replaces the hack-fix (revert non-export of __pte_offset_map) I had introduced a while ago.

What I was not able to do is to functionally test this (new) patch. Only compile-test.

Anyways, this patch is now included in the (letux)-6.6.y and (letux-)6.7-rc series.

And I will take another look why my changes have not been pushed to the github repo of
our Openpvrsgx-devgroup. Maybe because this is a manual task every now and then instead
of pushing automatically after each rebase to a new -rc).

BR and thanks,
Nikolaus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pvrsrv-1.17-osfunc-replace-__pte_offset_map_lock-by-.patch
Type: application/octet-stream
Size: 2275 bytes
Desc: not available
URL: <http://lists.goldelico.com/pipermail/openpvrsgx-devgroup/attachments/20231118/2f9cdd2c/attachment.obj>