[Letux-kernel] X1600 upstreaming efforts

[H. Nikolaus Schaller]

Hi,
I hope with 6.14.0 rolled out, I now have a little time to work on more x1600 upstreaming.

I have started with the x1600 USB PHY

There were some glitches in formatting of old and new macros, but otherwise it is fine.

But checkpatch complained about a missing bindings.yaml.

The is simple to add ingenic,x1600-phy except that we now must allow/require two register values.

So we need to make the maxItems value depend on the compatible enum.
This is beyond my knowledge of the YAML programming language.

So is there a good description how we can make this conditional?

Another minor complaint is:

CHECK: usleep_range is preferred over udelay; see function description of usleep_range() and udelay().
#84: FILE: drivers/phy/ingenic/phy-ingenic-usb.c:299:
+	udelay(500);
CHECK: usleep_range is preferred over udelay; see function description of usleep_range() and udelay().
#84: FILE: drivers/phy/ingenic/phy-ingenic-usb.c:299:
+	udelay(500);

Well, I think we can leave it as is until some maintainer requires a change.

BR,
Nikolaus

Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml

properties:
  $nodename:
    pattern: '^usb-phy at .*'

  compatible:
    enum:
      - ingenic,jz4770-phy
      - ingenic,jz4775-phy
      - ingenic,jz4780-phy
      - ingenic,x1000-phy
+      - ingenic,x1600-phy
      - ingenic,x1830-phy
      - ingenic,x2000-phy

  reg:
    maxItems: 1
+      - here we need something which makes a conditional 2...