[Letux-kernel] [PATCH 07/18] MIPS: DTS: jz4780: fix otg node as reported by dtbscheck

[H. Nikolaus Schaller]

Hi,

> Am 09.04.2022 um 14:27 schrieb Paul Cercueil <paul at crapouillou.net>:
> 
> Hi,
> 
> Le sam., avril 9 2022 at 13:15:37 +0200, Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> a écrit :
>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>> arch/mips/boot/dts/ingenic/ci20.dtb: usb at 13500000: compatible: 'oneOf' conditional failed, one must be fixed:
>>> 	['ingenic,jz4780-otg', 'snps,dwc2'] is too long
>>> 	['ingenic,jz4780-otg', 'snps,dwc2'] is too short
>>> 	'brcm,bcm2835-usb' was expected
>>> 	'hisilicon,hi6220-usb' was expected
>>> 	'rockchip,rk3066-usb' was expected
>>> 	'ingenic,jz4780-otg' is not one of ['rockchip,px30-usb', 'rockchip,rk3036-usb', 'rockchip,rk3188-usb', 'rockchip,rk3228-usb', 'rockchip,rk3288-usb', 'rockchip,rk3308-usb', 'rockchip,rk3328-usb', 'rockchip,rk3368-usb', 'rockchip,rv1108-usb']
>>> 	'lantiq,arx100-usb' was expected
>>> 	'lantiq,xrx200-usb' was expected
>>> 	'ingenic,jz4780-otg' is not one of ['amlogic,meson8-usb', 'amlogic,meson8b-usb', 'amlogic,meson-gxbb-usb', 'amlogic,meson-g12a-usb', 'intel,socfpga-agilex-hsotg']
>>> 	'amcc,dwc-otg' was expected
>>> 	'apm,apm82181-dwc-otg' was expected
>>> 	'snps,dwc2' was expected
>>> 	'st,stm32f4x9-fsotg' was expected
>>> 	'st,stm32f4x9-hsotg' was expected
>>> 	'st,stm32f7-hsotg' was expected
>>> 	'st,stm32mp15-fsotg' was expected
>>> 	'st,stm32mp15-hsotg' was expected
>>> 	'samsung,s3c6400-hsotg' was expected
>>> 	'intel,socfpga-agilex-hsotg' was expected
>> You really don't need to paste entire warning.
>>> 	From schema: Documentation/devicetree/bindings/usb/dwc2.yaml
>>> Signed-off-by: H. Nikolaus Schaller <hns at goldelico.com>
>>> ---
>>>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> index 2021836983c96..c5124459678b7 100644
>>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> @@ -576,7 +576,7 @@ bch: bch at 134d0000 {
>>>  	};
>>>  	otg: usb at 13500000 {
>>> -		compatible = "ingenic,jz4780-otg", "snps,dwc2";
>>> +		compatible = "snps,dwc2";
>> This looks wrong, the block usually should have a specific compatible.
>> Please mention why it does not.
> 
> Agreed. The "snps,dwc2" should be a fallback string, otherwise there is no way to uniquely identify the JZ4780 implementation of the IP.

Well, there is no specifc implementation and driver for it. So no need to uniquely identify it.

BR and thanks,
Nikolaus