[Letux-kernel] [PATCH 8/8] drm/ingenic: Attach bridge chain to encoders

H. Nikolaus Schaller hns at goldelico.com
Sun Aug 29 19:26:13 CEST 2021


Hi Paul,

> Am 29.08.2021 um 19:15 schrieb Paul Boddie <paul at boddie.org.uk>:
> 
> Nikolaus,
> 
> Sorry, I forgot the list on my last message. However, one thing I wanted to 
> add was about the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag...
> 
> On Sunday, 29 August 2021 18:59:59 CEST H. Nikolaus Schaller wrote:
>> 
>>> Am 29.08.2021 um 18:04 schrieb H. Nikolaus Schaller <hns at goldelico.com>:
>>> 
>>>               ret = drm_bridge_attach(encoder, &ib->bridge, NULL,
>>> -                                       DRM_BRIDGE_ATTACH_NO_CONNECTOR);
>>> +                                       0);
> 
> Apparently, the "new" model for display drivers according to drivers/gpu/drm/
> drm_bridge.c is that they create their own connector to refer to the chain of 
> bridges.

Would that mean that Paul C is forced to do it that way by new policy? Or
is it just his decision?

I get it right, ingenic-drm is a driver which should just make sure that a
connector exists. But can decide to leave it so the hdmi encoder?

> I honestly think that a few diagrams and not having to do object-oriented 
> programming the hard way would really help make this a lot clearer.

Indeed. But now we know.

What we don't know is if we should invest these extra hours to refactor the
dw-hdmi stuff. (Nobody is paying for - not even by learning something important).

BR,
Nikolaus




More information about the Letux-kernel mailing list