[Letux-kernel] [PATCH 1/3] MIPS: DTS: JZ4780: add EHCI/OHCI

H. Nikolaus Schaller hns at goldelico.com
Sat Sep 26 08:25:43 CEST 2020


> Am 25.09.2020 um 22:53 schrieb H. Nikolaus Schaller <hns at goldelico.com>:
> 
> (and accidentially i2s / codec)
> 
> Signed-off-by: H. Nikolaus Schaller <hns at goldelico.com>
> ---
> arch/mips/boot/dts/ingenic/jz4780.dtsi | 32 ++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index 19ad5f1ee00fc..653006df6d2d2 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -577,6 +577,38 @@ mmc1: mmc at 13460000 {
> 		status = "disabled";
> 	};
> 
> +	usb_phy: usb_phy {
> +		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
> +	};
> +
> +	ehci: ehci at 0x13490000 {
> +		compatible = "ingenic,jz4780-ehci", "generic-ehci";
> +		reg = <0x13490000 0x10000>;
> +
> +		interrupt-parent = <&intc>;
> +		interrupts = <20>;
> +
> +		clocks = <&cgu JZ4780_CLK_UHC>;

this seems to be pretty straight forward. 
And it is similar to the 3.18 kernel.

What I have added is the "generic-ehci" and the phy.

> +
> +		phys = <&usb_phy>;
> +//		phy-names = "usb2-phy";

Hm. Do we need a name here? There was a similar problem with the OTG phy
where the DWC2 driver did do different initialization depending on phy-names
present or not. It assumed two different styles of phy drivers.

And if we need the phy-names, how should it be defined? dwc2 drivers seems
to look for "usb2-phy" as well.

> +	};
> +
> +	ohci: ohci at 0x134a0000 {
> +		compatible = "ingenic,jz4780-ohci", "generic-ohci";
> +		reg = <0x134a0000 0x10000>;
> +
> +		interrupt-parent = <&intc>;
> +		interrupts = <5>;
> +
> +		clocks = <&cgu JZ4780_CLK_UHC>;
> +		clock-names = "uhc";
> +
> +		phys = <&usb_phy>;
> +//		phy-names = "usb2-phy";
> +	};
> +
> 	bch: bch at 134d0000 {
> 		compatible = "ingenic,jz4780-bch";
> 		reg = <0x134d0000 0x10000>;
> -- 
> 2.26.2
> 



More information about the Letux-kernel mailing list