[Letux-kernel] Fwd: [PATCH v6 0/7] leds: pwm: Make automatic labels work

[H. Nikolaus Schaller]

Interesting function for all leds (v5.10 or v5.11) I wasn't aware of.

It is described here:

https://elixir.bootlin.com/linux/v5.9-rc7/source/Documentation/devicetree/bindings/leds/common.yaml#L32
https://elixir.bootlin.com/linux/v5.9-rc7/source/include/dt-bindings/leds/common.h#L24

So we may update all our device tree files to make use of this feature.

An issue I see is with "function" since in many cases LEDs have no fixed function which can
be defined by the kernel. So we may have to choose LED_FUNCTION_INDICATOR for most of them.

BR,
Nikolaus


> Anfang der weitergeleiteten Nachricht:
> 
> Von: Alexander Dahl <post at lespocky.de>
> Betreff: [PATCH v6 0/7] leds: pwm: Make automatic labels work
> Datum: 1. Oktober 2020 um 01:46:30 MESZ
> An: linux-leds at vger.kernel.org, devicetree at vger.kernel.org, linux-kernel at vger.kernel.org, linux-arm-kernel at lists.infradead.org, linux-samsung-soc at vger.kernel.org, linux-omap at vger.kernel.org, linux-stm32 at st-md-mailman.stormreply.com, linux-amlogic at lists.infradead.org, linux-mips at vger.kernel.org
> Kopie: Pavel Machek <pavel at ucw.cz>, Dan Murphy <dmurphy at ti.com>, Rob Herring <robh+dt at kernel.org>, Alexander Dahl <ada at thorsis.com>, Peter Ujfalusi <peter.ujfalusi at ti.com>, Jacek Anaszewski <jacek.anaszewski at gmail.com>, Alexander Dahl <post at lespocky.de>
> 
> Hei hei,
> 
> for leds-gpio you can use the properties 'function' and 'color' in the
> devicetree node and omit 'label', the label is constructed
> automatically.  This is a common feature supposed to be working for all
> LED drivers.  However it did not yet work for the 'leds-pwm' driver.
> 
> This series removes platform_data support for the leds-pwm driver and
> takes the opportunity to update the leds-pwm dt-bindings accordingly.
> 
> After myself being one week on vacation patch 2/3 was already picked by
> Pavel and I gathered some more feedback on the remaining issues.
> 
> v6 was compile tested and dt_bindings_check and dtbs_check were run.
> 
> Note: I added some patches to fix DT schema warnings, but I did not put
> every reviewer/supporter/maintainer printed by get_maintainers in Cc to
> keep that list reasonable small.
> 
> Series changelog below …
> 
> Greets
> Alex
> 
> v6:
> - rebased series on recent pavel/for-next
> - added Reviewed-by from Marek to patch 1
> - patch 2 from v5 was picked by Pavel and is already in his for-next
>  branch
> - previous patch 3/3 (now 2/7) was reworked based on feedback by Rob
> - added more dt patches fixing warnings after binding conversion to yaml
> 
> v5:
> - replaced patch 1/3 by a new patch removing platform_data support for
>  the leds-pwm driver
> - little rewording of commit message in patch 2/3
> - updated patch 3/3 based on feedback by Rob Herring
> - added Marek Behún to Cc, because he also works on removing
>  platform_data support
> - rebased series on pavel/for-next
> 
> v4:
> - added led-class patch handling fwnode passing differently (patch 1/3)
> - adapted leds-pwm patch to new led-class (patch 2/3)
> - contacted original author of leds-pwm dt binding on license issue
>  (patch 3/3)
> 
> v3:
> - series rebased on v5.9-rc4
> - changed license of .yaml file to recommended one (patch 2/2)
> - added Acked-by to both patches
> 
> v2:
> - series rebased on v5.9-rc3
> - added the dt-bindings update patch (2/2)
> 
> v1:
> - based on v5.9-rc2
> - backport on v5.4.59 tested and working
> 
> Alexander Dahl (7):
>  leds: pwm: Remove platform_data support
>  dt-bindings: leds: Convert pwm to yaml
>  dt-bindings: mfd: Fix schema warnings for pwm-leds
>  ARM: dts: at91: smartkiz: Reference led node directly
>  ARM: dts: Fix schema warnings for pwm-leds
>  arm64: dts: meson: Fix schema warnings for pwm-leds
>  MIPS: DTS: img: Fix schema warnings for pwm-leds
> 
> .../devicetree/bindings/leds/leds-pwm.txt     | 50 -------------
> .../devicetree/bindings/leds/leds-pwm.yaml    | 70 +++++++++++++++++++
> .../devicetree/bindings/mfd/iqs62x.yaml       |  5 +-
> arch/arm/boot/dts/at91-kizbox.dts             | 10 +--
> arch/arm/boot/dts/at91-kizbox2-common.dtsi    |  8 +--
> arch/arm/boot/dts/at91-kizbox3-hs.dts         | 16 ++---
> arch/arm/boot/dts/at91-kizbox3_common.dtsi    | 10 +--
> arch/arm/boot/dts/at91-kizboxmini-common.dtsi |  8 +--
> arch/arm/boot/dts/at91-smartkiz.dts           |  6 +-
> arch/arm/boot/dts/at91sam9m10g45ek.dts        | 10 +--
> arch/arm/boot/dts/at91sam9rlek.dts            | 10 +--
> .../boot/dts/berlin2cd-google-chromecast.dts  |  6 +-
> arch/arm/boot/dts/exynos5422-odroidhc1.dts    |  4 +-
> arch/arm/boot/dts/exynos5422-odroidxu4.dts    |  4 +-
> .../boot/dts/exynos54xx-odroidxu-leds.dtsi    | 11 +--
> arch/arm/boot/dts/imx53-ppd.dts               | 15 ++--
> arch/arm/boot/dts/imx6qdl-cubox-i.dtsi        |  4 +-
> .../boot/dts/imx6sx-softing-vining-2000.dts   |  8 +--
> arch/arm/boot/dts/omap3-beagle-xm.dts         | 10 +--
> arch/arm/boot/dts/omap3-overo-base.dtsi       |  4 +-
> arch/arm/boot/dts/omap4-kc1.dts               |  6 +-
> arch/arm/boot/dts/omap4-sdp.dts               | 26 +++----
> arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts     | 12 ++--
> .../amlogic/meson-gxl-s905x-khadas-vim.dts    |  4 +-
> .../dts/amlogic/meson-gxm-khadas-vim2.dts     |  4 +-
> .../boot/dts/amlogic/meson-sm1-sei610.dts     |  8 +--
> arch/mips/boot/dts/img/pistachio_marduk.dts   |  5 +-
> drivers/leds/leds-pwm.c                       | 30 ++------
> 28 files changed, 184 insertions(+), 180 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
> create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml
> 
> 
> base-commit: 8fd8f94235c2c925d80b2316e0ab2bdd00af9bae
> -- 
> 2.20.1
>