[Letux-kernel] [PATCH 5/5] w1: omap-hdq: print dev_err if irq flags are not cleared
H. Nikolaus Schaller
hns at goldelico.com
Fri May 8 16:28:20 CEST 2020
for certain operations. They should not occur in normal
operation. Because of this this patch is optional.
Signed-off-by: H. Nikolaus Schaller <hns at goldelico.com>
---
drivers/w1/masters/omap_hdq.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
index ffcd6630f00d1..76bfa78aebf65 100644
--- a/drivers/w1/masters/omap_hdq.c
+++ b/drivers/w1/masters/omap_hdq.c
@@ -146,6 +146,10 @@ static int hdq_write_byte(struct hdq_data *hdq_data, u8 val, u8 *status)
goto rtn;
}
+ if (hdq_data->hdq_irqstatus)
+ dev_err(hdq_data->dev, "TX irqstatus not cleared (%02x)\n",
+ hdq_data->hdq_irqstatus);
+
*status = 0;
hdq_reg_out(hdq_data, OMAP_HDQ_TX_DATA, val);
@@ -243,6 +247,10 @@ static int omap_hdq_break(struct hdq_data *hdq_data)
goto rtn;
}
+ if (hdq_data->hdq_irqstatus)
+ dev_err(hdq_data->dev, "break irqstatus not cleared (%02x)\n",
+ hdq_data->hdq_irqstatus);
+
/* set the INIT and GO bit */
hdq_reg_merge(hdq_data, OMAP_HDQ_CTRL_STATUS,
OMAP_HDQ_CTRL_STATUS_INITIALIZATION | OMAP_HDQ_CTRL_STATUS_GO,
--
2.26.2
More information about the Letux-kernel
mailing list