[Letux-kernel] [PATCH] usb3503: Fix reset polarity

David Shah dave at ds0.me
Thu Jul 23 16:31:31 CEST 2020


It appears that the users of usb3503_reset expect state to be the
original active-low value.

Signed-off-by: David Shah <dave at ds0.me>
---
 drivers/usb/misc/usb3503.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
index e0c11331632a..9a228bc0566c 100644
--- a/drivers/usb/misc/usb3503.c
+++ b/drivers/usb/misc/usb3503.c
@@ -62,7 +62,7 @@ static int usb3503_reset(struct usb3503 *hub, int state)
 		gpiod_set_value_cansleep(hub->connect, 0);
 
 	if (hub->reset)
-		gpiod_set_value_cansleep(hub->reset, !state);
+		gpiod_set_value_cansleep(hub->reset, state);
 
 	/* Wait T_HUBINIT == 4ms for hub logic to stabilize */
 	if (state)
-- 
2.27.0



More information about the Letux-kernel mailing list