[Letux-kernel] [PATCH RFC] Bindings: nvmem: add bindings for JZ4780 efuse
Rob Herring
robh at kernel.org
Thu Feb 20 20:53:55 CET 2020
On Thu, Feb 20, 2020 at 12:00 AM Andreas Kemnade <andreas at kemnade.info> wrote:
>
> From: PrasannaKumar Muralidharan <prasannatsmkumar at gmail.com>
>
> This patch brings support for the JZ4780 efuse. Currently it only expose
> a read only access to the entire 8K bits efuse memory.
>
> Tested-by: Mathieu Malaterre <malat at debian.org>
> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar at gmail.com>
> Signed-off-by: Mathieu Malaterre <malat at debian.org>
> Signed-off-by: H. Nikolaus Schaller <hns at goldelico.com>
> [converted to yaml]
> Signed-off-by: Andreas Kemnade <andreas at kemnade.info>
> ---
> I will not update/maintain this, just have the impression that here some
> more work is needed to make somebody comfortable with yaml than stick
> to the usual pointing to documentation and I have not the ingredients
> for doing
> cat Antihistamines >/dev/brain ;-)
> and I do not want to see the other patches get lost.
Looks about right...
>
> .../bindings/nvmem/ingenic,jz4780-efuse.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
>
> diff --git a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
> new file mode 100644
> index 000000000000..ad56c17b0bd5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0
Dual license new bindings please:
(GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/ingenic,jz4780-efuse.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ingenic JZ EFUSE driver bindings
> +
> +maintainers:
> + - tbd <tbd at tbd>
> +
> +allOf:
> + - $ref: "nvmem.yaml#"
> +
> +properties:
> + compatible:
> + enum:
> + - ingenic,jz4780-efuse
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + # Handle for the ahb for the efuse.
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: bus_clk
My prior comment still applies.
Also, for a single clock, you don't really need a name.
> +
> +required:
> + - compatible
> + - reg
> + - clock
'make dt_binding_check' would have pointed the error here for you:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.example.dt.yaml:
efuse at 134100d0: 'clock' is a required property
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/jz4780-cgu.h>
> +
> + efuse at 134100d0 {
> + compatible = "ingenic,jz4780-efuse";
> + reg = <0x134100d0 0x2c>;
> +
> + clocks = <&cgu JZ4780_CLK_AHB2>;
> + clock-names = "bus_clk";
> + };
> +
> +...
> --
> 2.20.1
>
More information about the Letux-kernel
mailing list