[Letux-kernel] Understanding OMAP5 DPLL_ABE and CM_CLKSEL_WKUPAON

[H. Nikolaus Schaller]

Hi David,

> Am 02.12.2020 um 16:10 schrieb H. Nikolaus Schaller <hns at goldelico.com>:
> 
> Hi David,
> 
>> Am 01.12.2020 um 08:37 schrieb Tony Lindgren <tony at atomide.com>:
>> 
>> * H. Nikolaus Schaller <hns at goldelico.com> [201123 20:11]:
>>> Hi David and Tony,
>>> 
>>>> Am 28.07.2020 um 10:42 schrieb Tony Lindgren <tony at atomide.com>:
>>>> 
>>>> * David Shah <dave at ds0.me> [200727 08:58]:
>>>>> On Mon, 2020-07-27 at 01:28 -0700, Tony Lindgren wrote:
>>>>>> If it only needs to be configured to 1 for reboot, sounds like it
>>>>>> should
>>>>>> be set in omap44xx_restart(). And we should also set it to 1 for
>>>>>> omap4
>>>>>> too.
>>>>> 
>>>>> omap44xx_restart doesn't seem like the right place to me, as the bug
>>>>> also affects hard resets (i.e. NRESWARM assertion) and it would be nice
>>>>> to have these working, too.
>>>> 
>>>> Ah right, the device reboots fine, but the rebooted kernel
>>>> won't initialize properly.
>>>> 
>>>>> Would a better solution be to set it early during startup (the first
>>>>> part of clock init), and then clear it when the DPLLs are set up and
>>>>> locked?
>>>> 
>>>> Yes sounds like then the place to configure this is in the
>>>> drivers/clk/ti/clk-54xx.c omap5xxx_dt_clk_init(). Maybe add
>>>> a comment to the patch description that a similar patch may
>>>> be also needed for omap4 on some devices.
>>> 
>>> It seems as if the conclusion was that the patch is at the right
>>> location omap5xxx_dt_clk_init(). Has it been merged somewhere?
>>> 
>>> It seems as if we still need it in our 5.10-rc series:
>>> 
>>> https://git.goldelico.com/?p=letux-kernel.git;a=commit;h=aa8eda144e8faa185e154710ca0eef12adb2d29d
>> 
>> I recall Dave needs to resend it to the clock maintainers as
>> listed with scripts/get_maintainer.pl -f option.
> 
> Do you think you will find to push this upstream?

I hope your are well.

If you don't disagree I can add some of your original description
to the commit message and your and my signed-off and post it for
review.

BR and thanks,
Nikolaus