[Letux-kernel] [PATCH v2 5/5] rtc: rtc-rc5t619: add ricoh rc5t619 RTC driver

Andreas Kemnade andreas at kemnade.info
Fri Nov 29 12:25:01 CET 2019


On Fri, 29 Nov 2019 09:55:00 +0100
Alexandre Belloni <alexandre.belloni at bootlin.com> wrote:

> On 29/11/2019 07:59:40+0100, Andreas Kemnade wrote:
> > > > +	/* disable interrupt */
> > > > +	err = rc5t619_rtc_alarm_enable(&pdev->dev, 0);
> > > > +	if (err)
> > > > +		return err;    
> > > 
> > > Is it really useful to disable the alarm to reenable them later?
> > >   
> > Well, yes, seems to be nonsense.
> > Am I right that I do not need to prevent alarm irqs between
> > alloc() and register()?
> >   
> 
> That's fine, the core will be ready to handle alarms after alloc()
> 
ok, will clean that up and probably produce a -v3 this evening.

Regards,
Andreas


More information about the Letux-kernel mailing list