[Letux-kernel] [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

Andreas Kemnade andreas at kemnade.info
Fri Jan 18 20:38:47 CET 2019


On Fri, 18 Jan 2019 10:36:30 -0800
Tony Lindgren <tony at atomide.com> wrote:

> til the next workaround.
> > That flags also causes the iclk being enabled/disabled
> > manually.  
> Yes but SWSUP_IDLE for the interface clock to me currently
> just means:
> "manually enable and disable ocp interface clock"
well, if we want to manually disable it and not automatically,
we have to disable autoidle or it will be automatically disabled.

Disabling it manually when it is already auto-disabled (by autoidle) is
just practically a no-op towards the clock.

> and with your changes it becomes:
> "manually enable and disable ocp interface clock and block
>  autoidle while in use".
> So aren't we now changing the way things behave in general
Yes, we are, so proper testing is needed. But If I read those comments
it was always intended this way but not fully implemented because it
appeared to be more work like needing a usecounter (which my patchset
also adds) for that autoidle flag.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20190118/9d1d913a/attachment.asc>

More information about the Letux-kernel mailing list