[Letux-kernel] [PATCH pre-upstream RFC] media: omap3isp: Fix high idle current

[H. Nikolaus Schaller]

> Am 05.01.2019 um 11:46 schrieb Andreas Kemnade <andreas at kemnade.info>:
> 
> On Sat, 5 Jan 2019 11:33:23 +0100
> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
> 
>> Hi Andreas,
>> 
>>> Am 05.01.2019 um 10:17 schrieb Andreas Kemnade <andreas at kemnade.info>:
>>> 
>>> On the GTA04, current consumption rose by about 30mA when the omap3_isp
>>> module was loaded and the v4l device was not accessed and even no
>>> camera attached.
>>> Module removal fixed it again. Slowing down the removal process reveals
>>> that nothing that calling isp_detach_iommu() is required to have low
>>> current. So isp_attach/detach_iommu() to moved to the get()/put()
>>> functions.
>> 
>> To me there are one or two words missing to make the later sentences understandable.
>> 
> yes, there was some packet loss between /dev/brain and keyboard.
> Noticed it after sending the email and will fix it before submitting
> the patch to LKML.
> 
>> Maybe deepl.com en -> de and back to en?
>> 
>> Beim GTA04 stieg die Stromaufnahme um ca. 30mA, wenn das omap3_isp-Modul geladen wurde und auf das v4l-Gerät nicht zugegriffen und auch keine Kamera angeschlossen wurde.
>> Die Entfernung des Moduls hat es wieder behoben. Die Verlangsamung des Entfernungsprozesses zeigt, dass nichts, was den Aufruf von isp_detach_iommu() erfordert, um einen niedrigen Strom zu haben. Also isp_attach/detach_iommu(), um zu den Funktionen get()/put() zu wechseln.
>> 
>> Übersetzt mit www.DeepL.com/Translator
>> 
>> and back to -> en
>> 
>> With the GTA04 the current consumption increased by about 30mA if the omap3_isp module was loaded and the v4l device was not accessed and no camera was connected.
>> The removal of the module fixed it again. The slowing down of the removal process shows that nothing that requires isp_detach_iommu() to be called to have a low current. So isp_attach/detach_iommu() to switch to the get()/put() functions.
>> 
>> Translated with www.DeepL.com/Translator
>> 
>> Impressively good how it even works with () etc.
>> 
>>> 
>>> Signed-off-by: Andreas Kemnade <andreas at kemnade.info>
>>> ---
>>> As I am not completely sure about current state of our camera stuff,
>>> I am hesitating a bit here. I am doing now research of the actual state
>>> of the camera in the letux kernel. Last time I tried, it was not soo stable.
>>> But at least it fixes a problem in devices without camera.
>> 
>> Yes, that is fine. I'll take it for letux-4.21-rc1. Should I also add to
>> 4.20.1?
>> 
> I think that would be a good idea.
> 
>> The status is that the camera driver seems to work - but only once.
>> I was able to get images through mplayer but when stopping and restarting
>> I only got select timeouts and a green screen.
> 
> So at least the patch does not make things worse?

I haven't tested the camera for a while, but I don't think it makes it
worse. And if it does, we have a hint why the camera isn't working well :)

BR and thanks,
Nikolaus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20190105/b349ea0b/attachment.asc>