[Letux-kernel] wwan logic inversion

H. Nikolaus Schaller hns at goldelico.com
Fri Nov 23 18:19:07 CET 2018


Hi,

> Am 23.11.2018 um 18:02 schrieb Andreas Kemnade <andreas at kemnade.info>:
> 
> On Fri, 23 Nov 2018 17:41:26 +0100
> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
> 
> [...]
>>> using devmem2 for gpio toggle fixes the logic.
>>> root at gta04:/sys/firmware/devicetree/base/modem# xxd on-indicator-gpio
>>> 0000000: 0000 0000                                ....
>>> 
>>> That does not look good.
> [...]
>> 
>> If it differs, we have to check DT and the wwan driver if we forgot
>> to forward-port some patch in 4.19.
>> 
> Well, as you have seen, I have checked dt, no indicator gpio there (set
> to zero)

There seems to be a diff between 4.18 and 4.19:

iMac:master hns$ git diff letux-4.18.20 letux-4.19.3 arch/arm/boot/dts/omap3-gta04a5.dts
diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts
index add86ca39874..32b13a75322b 100644
--- a/arch/arm/boot/dts/omap3-gta04a5.dts
+++ b/arch/arm/boot/dts/omap3-gta04a5.dts
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014-16 H. Nikolaus Schaller <hns at goldelico.com>
+ * Copyright (C) 2014-18 H. Nikolaus Schaller <hns at goldelico.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
@@ -24,11 +24,7 @@
        };

        sound {
-//             ti,jack-det-gpio = <&twl_gpio 2 GPIO_ACTIVE_HIGH>;    /* GTA04A5 only */
-       };
-
-       modem_en: modem { /* control modem power through rfkill */
-               on-indicator-gpio = <&twl_gpio 6 GPIO_ACTIVE_HIGH>;     /* GTA04A5 only: reset_out feedback from modem */

^^^ this should not have been deleted by accident

+               ti,jack-det-gpio = <&twl_gpio 2 GPIO_ACTIVE_HIGH>;      /* GTA04A5 only */
        };

        wlan_en: wlan_en_regulator {
@@ -39,7 +35,7 @@
                regulator-min-microvolt = <1800000>;
                regulator-max-microvolt = <1800000>;

-               gpio = <&gpio5 10 GPIO_ACTIVE_HIGH>;    /* GPIO_138 */
+               gpio = <&gpio5 10 GPIO_ACTIVE_HIGH>;    /* GPIO_138 */

                startup-delay-us = <70000>;
                enable-active-high;
@@ -136,7 +132,6 @@

 &mmc2 {
        vmmc-supply = <&wlan_en>;
-       non-removable;
        bus-width = <4>;
        cap-power-off-card;
        non-removable;
iMac:master hns$

It also appears to be missing in 4.20-rc3.

Unfortunately it is a little difficult to find a patch that has removed a specific line of code.
Finding the one that introduced a change is a simple git blame + grep

BR,
Nikolaus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20181123/a396a56d/attachment.asc>


More information about the Letux-kernel mailing list