[Letux-kernel] [PATCH letux 0/3] GTA04A3/4 Bluetooth via serdev

H. Nikolaus Schaller hns at goldelico.com
Mon Nov 12 09:45:59 CET 2018


Hi,

> Am 11.11.2018 um 22:07 schrieb Andreas Kemnade <andreas at kemnade.info>:
> 
> Hi,
> 
> On Sun, 11 Nov 2018 21:46:26 +0100
> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
> 
>> Cool!
>> 
>> I didn't expect that it is that easy.
>> 
>>> Am 11.11.2018 um 20:49 schrieb Andreas Kemnade <andreas at kemnade.info>:
>>> 
>>> This frees us from needing hciattach.
>>> 
>>> On mainline it requires ifconfig wlan0 up, because a
>>> powerseq patch is missing.
>> 
>> Is there a problem upstreaming it as well?
>> 
> Needs to be reworked, but I remember you had ideas.
> The question is whether we can do that separately because the problem
> is already there when you use hciattach.

Ok, I'll have a look at it.

> 
>>> hciconfig hci0 up will only work then
>>> Proper close/open of the serial device when not needed
>>> is not included, nobody seems to do it now, so it is a general
>>> thing, so you have to use rmmod hci_uart.
>>> 
>>> Andreas Kemnade (3):
>>> bluetooth: add uart h4 devices via serdev/devicetree
>>> bluetooth: add regulators for h4 serdevs
>>> arm: dts: gta04: add bluetooth serdev
>>> 
>>> arch/arm/boot/dts/omap3-gta04.dtsi |  6 +++
>>> drivers/bluetooth/hci_h4.c         | 94 ++++++++++++++++++++++++++++++++++++++
>>> 2 files changed, 100 insertions(+)
>>> 
>> 
>> I'll give it a try asap.
>> 
>> Do you have some git for the patches?
>> 
> I was unsure what to do because you are reorganizing.
> https://github.com/akemnade/linux/
> gta04-bt

Thanks! I have merged it and tested a little and after disabling the old w2bw driver it works!

> 
>> The arch/arm/boot/dts/omap3-gta04.dtsi patch seems to duplicate things a little
>> we already have in the 4.20-rc queue, but also adds new things (speed, flow).
>> 
> Well, I made the things on top of mainline 4.20-rc1.

Ah, ok. letux-4.20-rc1 has a bluetooth serdev node for long time (for our own
special driver).

I have rebased things and the addition of flow and speed remain.

Well, the patches got a little separated, because we cut things differently (dt-gta04 and drivers).
Which is not a big problem since maintainers also want to separate new drivers and DT modifications
(different mailing lists).

The driver code will be in letux/bluetooth-h4-serdev

So let me rebase to letux-4.20-rc2 now and then we can add the missing pieces like bindings doc.
And test a little more. And check the powerseq patch so that we finally can upstream a complete
bluetooth solution for all gta04 device variants.

BR and thanks,
Nikolaus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20181112/85f49e65/attachment.asc>


More information about the Letux-kernel mailing list