[Letux-kernel] [PATCH 0/2] power: generic-adc-battery: fix out of bounds write

Andreas Kemnade andreas at kemnade.info
Wed Jun 27 07:28:54 CEST 2018


On Tue, 26 Jun 2018 21:01:31 +0200
"H. Nikolaus Schaller" <hns at goldelico.com> wrote:

> Hi,
> > Am 26.06.2018 um 20:13 schrieb Belisko Marek <marek.belisko at gmail.com>:
> > 
> > Hi,
> > 
> > those patches was already posted but was refused to merge because
> > Pavel + Sebastian was talking about libbattery approach so it was not
> > acceptable for them.  
> Well, we might start another attempt, since there is no libbattery.
> IMHO, Pavel started one but nobody jumped on his train.
> Or is there one now?
> But I think Andreas meant a handful of patches that should fix the
> gab-driver and improve DT management.
yes, what I do not have seen is that some seem to fix things introduced by 
charge calculation:
commit dbd3ea3f846ac64a24bb0cc168bd6971d9e70ded
Author: H. Nikolaus Schaller <hns at goldelico.com>
Date:   Sat Nov 18 12:09:52 2017 +0100

    generic-adc-battery: fix NULL pointer dereference and provide estimate for mAh of charge
    In DT-only systems there is no cal_charge function pointer defined by
    a board file. Don't try to call this (*NULL)()
    Signed-off-by: H. Nikolaus Schaller <hns at goldelico.com>

> IMHO they were not happy to have the kernel calculate/estimate remaining
> capacity. If that was (and is) their only concern, we should repack that
> into a separate set of patches.

well, at least try to reorder the questionable patches on top of a set of
fixes. And then we start with the easy things.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20180627/90cb3058/attachment.asc>

More information about the Letux-kernel mailing list