[Letux-kernel] New LetuxOS Kernels - strcmp(NULL)

[H. Nikolaus Schaller]

Hi Tony,

> Am 21.06.2018 um 08:42 schrieb Tony Lindgren <tony at atomide.com>:
> 
> * H. Nikolaus Schaller <hns at goldelico.com> [180620 15:36]:
>> [    7.154541] i2c 1-0030: Retrying from deferred list
>> [    7.164642] pinctrl_generic_add_group: pctldev=ee3bc200 name=pinmux_camera_pins found selector=19
>> [    7.174285] w1_master_driver w1_bus_master1: Attaching one wire slave 01.000000000000 crc 3d
>> [    7.196868] pcs_dt_free_map
>> [    7.205200] i2c 1-0030: Retrying from deferred list
>> [    7.217590] bq27xxx_battery_setup
>> [    7.225982] pinctrl_generic_add_group: pctldev=ee3bc200 name=pinmux_camera_pins found selector=19
>> [    7.235565] bq27xxx_battery_setup: dm_regs=  (null)
>> [    7.248168] (NULL device *): hwmon: 'bq27000-battery' is not a valid name attribute, please fix
> 
> Hmm what's up with this warning above? Is that NULL related to
> pinctrl issue?

No. It is just that the dev->name is a NULL:

https://elixir.bootlin.com/linux/v4.18-rc1/source/drivers/hwmon/hwmon.c#L556

There are some historic rules for hwmon devices and a "-" is not allowed.

On successful boot we have the same message.

> 
>> [    7.257446] bq27xxx_battery_settings
>> [    7.261535] pcs_dt_free_map
>> [    7.274200] bq27xxx_battery_settings: power_supply_get_battery_info failed ret=-1088290796
>> [    7.322113] pcs_dt_free_map
>> [    7.356658] i2c 1-0030: Retrying from deferred list
> 
> 
>> [    7.363830] (NULL device *): hwmon: 'gta04-battery' is not a valid name attribute, please fix
>> [    7.373260] pinctrl_generic_add_group: pctldev=ee3bc200 name=pinmux_camera_pins found selector=19
>> [    7.386840] pcs_dt_free_map
>> [    7.394378] platform backlight: Retrying from deferred list
>> [    7.406372] pinctrl_generic_get_group_name: group>name is NULL
> 
> So what's the selector number here when group->name == NULL?
> Still 19 (or again 19 for a new entry) or something else?

Ok, I'll try to printk for this.

BR and thanks,
Nikolaus