[Letux-kernel] Bug in i2c_device_probe

[Tony Lindgren]

* Belisko Marek <marek.belisko at gmail.com> [180615 20:43]:
> Hi Tony, Nikolaus,
> On Mon, Jun 11, 2018 at 9:08 AM Tony Lindgren <tony at atomide.com> wrote:
> >
> > * H. Nikolaus Schaller <hns at goldelico.com> [180610 08:33]:
> > > Hi Tony,
> > > I've observed this message on the Pyra with letux-4.17.0-lpae kernel:
> > >
> > > [    1.806477] platform 48070000.i2c: Retrying from deferred list
> > > [    1.813802] ------------[ cut here ]------------
> > > [    1.818666] WARNING: CPU: 1 PID: 778 at drivers/irqchip/irq-gic.c:1016 gic_irq_domain_translate+0x78/0x100
> I tried following patch:
> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi
> b/arch/arm/boot/dts/omap5-board-common.dtsi
> index 218892b..75684c5 100644
> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> @@ -393,7 +393,7 @@
> 
>         palmas: palmas at 48 {
>                 compatible = "ti,palmas";
> -               interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* IRQ_SYS_1N */
> +               interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N */
>                 reg = <0x48>;
>                 interrupt-controller;
>                 #interrupt-cells = <2>;
> @@ -425,7 +425,7 @@
>                 rtc {
>                         compatible = "ti,palmas-rtc";
>                         interrupt-parent = <&palmas>;
> -                       interrupts = <8 IRQ_TYPE_NONE>;
> +                       interrupts = <8 IRQ_TYPE_LEVEL_HIGH>;
>                         ti,backup-battery-chargeable;
>                         ti,backup-battery-charge-high-current;
>                 };
> @@ -443,7 +443,7 @@
>                 palmas_pmic {
>                         compatible = "ti,palmas-pmic";
>                         interrupt-parent = <&palmas>;
> -                       interrupts = <14 IRQ_TYPE_NONE>;
> +                       interrupts = <14 IRQ_TYPE_LEVEL_HIGH>;
>                         interrupt-names = "short-irq";
> 
>                         ti,ldo6-vibrator;
> @@ -659,7 +659,7 @@
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&twl6040_pins>;
> 
> -               interrupts = <GIC_SPI 119 IRQ_TYPE_NONE>; /*
> IRQ_SYS_2N cascaded to gic */
> +               interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; /*
> IRQ_SYS_2N cascaded to gic */
> 
>                 /* audpwron gpio defined in the board specific dts */
> 
> 
> and it looks like board boots fine.

OK good to hear. Can you please post a proper fix to the the
linux-omap and LAKML lists?

Regards,

Tony