[Letux-kernel] [PATCH 04/32] ARM: dts: omap3-gta04: fixes for tvout / venc

H. Nikolaus Schaller hns at goldelico.com
Wed Jul 25 14:31:48 CEST 2018


Hi Sebastian,

> Am 25.07.2018 um 12:37 schrieb Sebastian Reichel <sebastian.reichel at collabora.co.uk>:
> 
> Hi,
> 
> On Wed, Jul 25, 2018 at 08:58:36AM +0200, H. Nikolaus Schaller wrote:
>> 			port at 1 {
>> -				reg = <1>;
>> +				reg = <0>;
> 
> You should also update the node name.

I did take another look at this and we might have the wrong fix here anyways.
The first indication is that a port at 0 already exists soI can't simply rename
the node.

The opa362 is an exceptional dssdev since it has an input and an output port
which should be differentiated by the reg property and the node name.

Ports are apparently matched by reg number, i.e. here:

	https://elixir.bootlin.com/linux/v4.18-rc6/source/drivers/gpu/drm/omapdrm/dss/output.c#L146

The issue seems to be that the driver does not set the out->port_num of the endpoint to 1.

	https://elixir.bootlin.com/linux/v4.18-rc6/source/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c#L205

So the <1> does not match and we were just lucky to make it working by choosing <0> in the DT.

I'll need a little time to test if a (one-liner) patch for the driver does the same/right thing.

And since it is omapdss related I've put Tomi on CC:

BR,
Nikolaus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20180725/5231e76b/attachment.asc>


More information about the Letux-kernel mailing list