[Letux-kernel] [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings

Kalle Valo kvalo at codeaurora.org
Wed Jul 25 10:40:30 CEST 2018


"H. Nikolaus Schaller" <hns at goldelico.com> writes:

>> Am 25.07.2018 um 08:40 schrieb Kalle Valo <kvalo at codeaurora.org>:
>> 
>> "H. Nikolaus Schaller" <hns at goldelico.com> writes:
>> 
>>> wl1271_warning() already appends a \n to the format,
>>> so adding one to the warning string gives empty lines in the log.
>>> 
>>> Signed-off-by: H. Nikolaus Schaller <hns at goldelico.com>
>> 
>> "drivers: net:" in the title is unnecessary, but I can remove that.
>
> Ok, thanks! I wasn't aware of the precise subsystem tagging style here.

Yeah, subsystems can do it a bit differently. But you can easily check
with git log the preferred style:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject

-- 
Kalle Valo


More information about the Letux-kernel mailing list