[Letux-kernel] LetuxOS Xmas-Kernel edition

H. Nikolaus Schaller hns at goldelico.com
Sun Dec 30 14:57:48 CET 2018


Hi,

> Am 30.12.2018 um 14:52 schrieb Andreas Kemnade <andreas at kemnade.info>:
> 
> On Sun, 30 Dec 2018 14:30:44 +0100
> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
> 
>> Hi,
>> 
>>> Am 30.12.2018 um 14:17 schrieb Andreas Kemnade <andreas at kemnade.info>:
>>> 
>>> On Tue, 25 Dec 2018 10:45:51 +0100
>>> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
>>> 
>>>> Hi all,
>>>> we have got an Xmas present that new kernel releases are available:
>>>> 
>>>> letux-4.20:
>>>> * rebased onto letux-base=v4.20
>>>> * Pyra: fixes omap dss / panel driver which makes it work again :)
>>>> * GTA15: add feature branch letux/vcnl4000
>>>> * Pyra/GTA15: move display backlight definitions to pyra-display.dtsi
>>>> * rename CONFIG constants for DRM/OMAP panels and encoders
>>>> * fix rebase conflict in mmc: host: omap_hsmmc: Enable ADMA2
>>>> * remove a private Darwin HOSTCC fix for __gnu_inline etc. because it was now fixed upstream
>>>> 
>>> 
>>> andi at aktux:~/gta04/pyra-kernel$ grep BOE arch/arm/configs/letux_*
>>> arch/arm/configs/letux_defconfig:# CONFIG_DRM_OMAP_BOE_W677L is not set
>>> arch/arm/configs/letux_lpae_defconfig:# CONFIG_DRM_OMAP_BOE_W677L is not set
>>> arch/arm/configs/letux_udoo_defconfig:# CONFIG_DRM_OMAP_BOE_W677L is not set
>>> 
>>> no panel anymore?
>>> This is commit
>>> d68e9358309d7bf31d9629076ed0816ace1fab96  
>> 
>> There seems to be a bug in
>> 
>> http://git.goldelico.com/?p=letux-kernel.git;a=blobdiff;f=arch/arm/configs/letux_defconfig;h=9b6d3abc81d255c92838e6881e28f80d56bb1336;hp=9a994af3713aa807b242ca2b613d3950b7cd486b;hb=eb97939a669bd8722c95ed416cd516e56bf90aaf;hpb=366df6be44b66fe01a8dbe3310fd3d89e87c3547
>> 
>> which does not properly reflect
>> 
>> http://git.goldelico.com/?p=letux-kernel.git;a=commit;h=7e2cd677d09234f9bb72d070e59c3c5bc06112a1
>> 
>> I'll fix it for 4.20.1. YOu can just set CONFIG_DRM_OMAP_BOE_W677L=m
>> 
> no. There is a mismatch between Kconfig/Makefile in naming. BTW: Why it
> is non the same scheme as the other omap panels?

Exactly that is the intention of these fixes to have them in sync with the upstream config names.

If it isn't the patches are not perfect and need to be fixed...

> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/Makefile b/drivers/gpu/drm/omapdrm/displays/Makefile
> index fe82d1211dea..ee11d10ea408 100644
> --- a/drivers/gpu/drm/omapdrm/displays/Makefile
> +++ b/drivers/gpu/drm/omapdrm/displays/Makefile
> @@ -14,7 +14,7 @@ obj-$(CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o
> obj-$(CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o
> obj-$(CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o
> obj-$(CONFIG_DRM_OMAP_PANEL_LG_LH500WF1) += panel-lg-lh500wf1.o
> -obj-$(CONFIG_DRM_OMAP_PANEL_BOE_W677L) += panel-boe-w677l.o
> +obj-$(CONFIG_DRM_OMAP_BOE_W677L) += panel-boe-w677l.o
> obj-$(CONFIG_DRM_OMAP_PANEL_SUCCESS_S90451) += panel-success-s90451.o
> obj-$(CONFIG_DRM_OMAP_PANEL_MIPI_DEBUG) += panel-mipi-debug.o
> obj-$(CONFIG_DRM_OMAP_ENCODER_SOLOMON_SSD2858) += encoder-solomon-ssd2858.o
> 
> I think we should rather fix it on Kconfig side.

We should fix it where the fix didn't fix what it should quickly fix...

BR,
Nikolaus



More information about the Letux-kernel mailing list