[Letux-kernel] [PATCH letux] panel-boe-w667l: hack-fix disapble oopses

Andreas Kemnade andreas at kemnade.info
Sat Dec 1 09:04:23 CET 2018


Hi,

panel-dsi-cm also seems not to do in->opes->disable(),
so maybe it should really be removed.

Regards,
Andreas

On Fri, 30 Nov 2018 23:09:09 +0100
Andreas Kemnade <andreas at kemnade.info> wrote:

> no idea if this is right, what the real fix is.
> depends on:
> https://patchwork.kernel.org/cover/10692757/
> 
> Signed-off-by: Andreas Kemnade <andreas at kemnade.info>
> ---
>  drivers/gpu/drm/omapdrm/displays/panel-boe-w677l.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-boe-w677l.c b/drivers/gpu/drm/omapdrm/displays/panel-boe-w677l.c
> index 5db180711d79..b3a86d66b028 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-boe-w677l.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-boe-w677l.c
> @@ -786,16 +786,24 @@ static void w677l_disable(struct omap_dss_device *dssdev)
>  
>  	ddata->enabled = 0;
>  	in->ops->dsi.disable_video_output(in, ddata->pixel_channel);
> -	in->ops->disable(in);
> +	dev_dbg(&ddata->pdev->dev, "disabled video()\n");
> +	if (in->ops->disable) {
> +		in->ops->disable(in);
> +	} else {
> +		dev_dbg(&ddata->pdev->dev, "no disable op??\n");
> +	}
> +	dev_dbg(&ddata->pdev->dev, "disabled in()\n");
>  	mdelay(10);
>  	w677l_reset(dssdev, true);	/* activate reset */
>  	w677l_regulator(dssdev, false);	/* switch power off - after stopping video stream */
>  	mdelay(20);
>  	/* here we can also power off IOVCC */
>  
> +	dev_dbg(&ddata->pdev->dev, "unlock bus()\n");
>  	in->ops->dsi.bus_unlock(in);
>  
>  	mutex_unlock(&ddata->lock);
> +	dev_dbg(&ddata->pdev->dev, "disable finished)\n");
>  
>  	dssdev->state = OMAP_DSS_DISPLAY_DISABLED;
>  }

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20181201/5b1f9392/attachment.asc>


More information about the Letux-kernel mailing list