[Letux-kernel] 4.16 onenand

[H. Nikolaus Schaller]

Hi,

> Am 11.04.2018 um 22:18 schrieb Andreas Kemnade <andreas at kemnade.info>:
> 
> On Wed, 11 Apr 2018 11:55:35 +0200
> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
> 
>> Hi all,
>> 
>>> Am 10.04.2018 um 22:37 schrieb Andreas Kemnade <andreas at kemnade.info>:
>>> 
>>> On Tue, 10 Apr 2018 16:06:54 +0200
>>> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
>>> 
>>> [...]  
>>>> 
>>>> This commit has the following message:
>>>> 
>>>> commit bdaca9345d41fd9420995469d27603ea62054691
>>>> Author: Ladislav Michl <ladis at linux-mips.org>
>>>> Date:   Fri Jan 12 14:16:57 2018 +0100
>>>> 
>>>>   mtd: onenand: omap2: Decouple DMA enabling from INT pin availability
>>>> 
>>>>   INT pin (gpio_irq) is not really needed for DMA but only for notification
>>>>   when a command that needs wait has completed. DMA memcpy can be still used
>>>>   even without gpio_irq available, so enable it unconditionally.
>>>> 
>>>>   Signed-off-by: Ladislav Michl <ladis at linux-mips.org>
>>>>   Reviewed-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
>>>>   Tested-by: Tony Lindgren <tony at atomide.com>
>>>>   Tested-by: Aaro Koskinen <aaro.koskinen at iki.fi>
>>>>   Acked-by: Roger Quadros <rogerq at ti.com>
>>>>   Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
>>>> 
>>>> 
>>>> This is a really hot candidate!
>>>> 
>>> reproducable here.  
>> 
>> it looks as we have a solution now!
>> 
>> I will spend some more minutes for testing and then finally
>> I can rebuilt & update/release our letux-4.16 for the GTA04A5.
>> 
>> This will also include the missing EHCI/offmode stuff.
>> 
>> There was only one minor issue in the boot log:
>> 
>> [    7.456390] omap-twl4030 sound: twl4030-hifi <-> 49022000.mcbsp mapping ok
>> [    7.539764] asoc-simple-card sound_telephony: gtm601 <-> 49026000.mcbsp mapping ok
>> [    7.555938] ov9655 1-0030: OV9655 read register 1c : ffffff87
>> [    7.575683] ov9655 1-0030: OV9655 read register 1d : ffffff87
>> [    7.581695] ov9655 1-0030: OV9655 not detected, can't read manufacturer id
>> [    7.619445] pps pps0: new PPS source pps.-1
>> [    7.623901] pps pps0: Registered IRQ 165 as PPS source
>> [    7.647369] clk_unregister: unregistering prepared clock: cam_xclka
>> [    7.654144] ------------[ cut here ]------------
>> [    7.774383] WARNING: CPU: 0 PID: 1143 at lib/refcount.c:187 refcount_sub_and_test+0x44/0x98
>> [    7.825897] refcount_t: underflow; use-after-free.
>> [    7.830932] Modules linked in: pps_gpio panel_tpo_td028ttec1 snd_soc_simple_card snd_soc_simple_card_utils snd_soc_omap_twl4030 pps_core encoder_opa362 wwan_on_off snd_soc_gtm601 pwm_omap_dmtimer connector_analog_tv generic_adc_battery pwm_bl extcon_gpio omap3_isp(+) wlcore_sdio videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 bq27xxx_battery_hdq bq27xxx_battery videobuf2_common omap2430 omap_hdq ov9655 v4l2_fwnode bmg160_i2c bmp280_i2c 
> 
> There is a (+) for omap3_isp. Maybe that is a hint?

Interesting!

> 
> I cannot reproduce it on my gta04a5.

Do you have a camera installed?
I guess it has something to do with 

>>  clk_unregister: unregistering prepared clock: cam_xclka

So if you have a camera it may work (have not tried).
If you block omap3_isp it is not even tried.

I have two GTA04A4, one with camera and one without.
Maybe, I should look if they also show this effect.

BR,
Nikolaus

> 
> module diff:
> 
> $ diff -u mod.hns mod.ak 
> --- mod.hns	2018-04-11 22:11:59.067206123 +0200
> +++ mod.ak	2018-04-11 22:10:55.087204691 +0200
> @@ -1,4 +1,7 @@
> +Module
> +arc4
> at24
> +bluetooth
> bmc150_accel_core
> bmc150_accel_i2c
> bmc150_magn
> @@ -7,23 +10,45 @@
> bmg160_i2c
> bmp280
> bmp280_i2c
> +bnep
> bno055
> bq27xxx_battery
> bq27xxx_battery_hdq
> +cec
> +cfbcopyarea
> +cfbfillrect
> +cfbimgblt
> +cfg80211
> +configfs
> connector_analog_tv
> +dax
> +dm_crypt
> +dm_mod
> +drm
> +drm_kms_helper
> +drm_panel_orientation_quirks
> +ecdh_generic
> encoder_opa362
> extcon_gpio
> +fb_sys_fops
> +g_ether
> generic_adc_battery
> gpio_twl4030
> +gps_core
> industrialio
> industrialio_triggered_buffer
> +ipv6
> kfifo_buf
> leds_tca6507
> +libcomposite
> +mac80211
> media
> musb_hdrc
> omap2430
> -omap3_isp(+)
> omap_hdq
> +omapdrm
> +omapdss
> +omapdss_base
> ov9655
> panel_tpo_td028ttec1
> phy_twl4030_usb
> @@ -39,18 +64,23 @@
> snd_soc_simple_card
> snd_soc_simple_card_utils
> snd_soc_twl4030
> +syscopyarea
> +sysfillrect
> +sysimgblt
> tsc2007
> twl4030_charger
> twl4030_madc
> twl4030_pwrbutton
> twl4030_vibra
> +u_ether
> +usb_f_ecm
> +usb_f_rndis
> v4l2_common
> v4l2_fwnode
> -videobuf2_common
> -videobuf2_dma_contig
> -videobuf2_memops
> -videobuf2_v4l2
> videodev
> +w2cbw003_bluetooth
> w2sg0004
> +wl18xx
> +wlcore
> wlcore_sdio
> wwan_on_off
> 
> 
> Regards,
> Andreas