[Letux-kernel] [PATCH] letux/gta04: do not mess with RTC_HOURS

Andreas Kemnade andreas at kemnade.info
Thu Feb 2 19:33:22 CET 2017


Hi Nikolaus,


On Thu, 2 Feb 2017 19:17:27 +0100
"H. Nikolaus Schaller" <hns at goldelico.com> wrote:

> Ah, you were faster!
> 
> Could you please add a description why it is wrong and what has
> changed? It looks as if the function parameter sequence has changed.

parameter order was wrong, yes.
But in twl4030-additions.c I did not find any wrong usage, so why
did that not harm earlier...?
That line it part of a bigger commit just copying files over.

Regards,
Andreas

> 
> BR and thanks,
> Nikolaus
> 
> > Am 02.02.2017 um 19:13 schrieb Andreas Kemnade
> > <andreas at kemnade.info>:
> > 
> > Signed-off-by: Andreas Kemnade <andreas at kemnade.info>
> > ---
> > board/goldelico/letux-gta04/gta04.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/board/goldelico/letux-gta04/gta04.c
> > b/board/goldelico/letux-gta04/gta04.c index 5c93d26..46ccb94 100644
> > --- a/board/goldelico/letux-gta04/gta04.c
> > +++ b/board/goldelico/letux-gta04/gta04.c
> > @@ -359,9 +359,9 @@ static void tps65950_init(void)
> > #define TWL4030_BB_CFG_BBISEL_500UA	2
> > 	
> > 	/* Enable battery backup capacitor (3.2V, 0.5mA charge
> > current) */
> > -	twl4030_i2c_write_u8(TWL4030_CHIP_PM_RECEIVER,
> > +	twl4030_i2c_write_u8(TWL4030_CHIP_PM_RECEIVER,
> > TWL4030_PM_RECEIVER_BB_CFG, TWL4030_BB_CFG_BBCHEN |
> > TWL4030_BB_CFG_BBSEL_3200MV |
> > -
> > TWL4030_BB_CFG_BBISEL_500UA, TWL4030_PM_RECEIVER_BB_CFG);
> > +
> > TWL4030_BB_CFG_BBISEL_500UA); #endif
> > 	
> > }
> > -- 
> > 2.1.4
> > 
> > _______________________________________________
> > http://projects.goldelico.com/p/gta04-kernel/
> > Letux-kernel mailing list
> > Letux-kernel at openphoenux.org
> > http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
> 
> _______________________________________________
> http://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel at openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20170202/a4b5d029/attachment.asc>


More information about the Letux-kernel mailing list