[Letux-kernel] regression: drm/omapdrm: Move commit_modeset_enables() before commit_planes()

H. Nikolaus Schaller hns at goldelico.com
Thu Apr 20 22:52:12 CEST 2017


Hi,

> Am 20.04.2017 um 12:26 schrieb Andreas Kemnade <andreas at kemnade.info>:
> 
> Hi,
> 
> On Thu, 20 Apr 2017 11:00:09 +0200
> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
> 
> 
>> But I still have some debugging messages when Xorg starts (omap-drm driver), that were not in kernels up to 4.10.
>> I am not sure if they are related or something else:
>> 
>> [   52.767211] ------------[ cut here ]------------
>> [   52.772521] WARNING: CPU: 0 PID: 2260 at drivers/gpu/drm/omapdrm/omap_gem.c:938 omap_gem_put_paddr+0x30/0x60 [omapdrm]
>> [   52.805419] Modules linked in: bnep bluetooth usb_f_ecm g_ether usb_f_rndis u_ether libcomposite configfs ipv6 hso bq27xxx_battery omapdrm panel_tpo_td028ttec1 drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea drm snd_soc_simple_card snd_soc_simple_card_utils snd_soc_omap_twl4030 encoder_opa362 twl4030_madc_hwmon snd_soc_gtm601 pwm_omap_dmtimer connector_analog_tv generic_adc_battery pwm_bl extcon_gpio omap3_isp videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 ov9650 w1_bq27000 videobuf2_core v4l2_common omap_hdq omap2430 bmp280_i2c at24 bmp280 itg3200 phy_twl4030_usb nvmem_core videodev hmc5843_i2c lis3lv02d_i2c bma180 snd_soc_omap_mcbsp hmc5843_core industrialio_triggered_buffer lis3lv02d snd_soc_omap tsc2007 media leds_tca6507 input_polldev kfifo_buf
>> [   52.881042]  snd_pcm_dmaengine musb_hdrc gpio_twl4030 snd_soc_twl4030 twl4030_madc twl4030_pwrbutton twl4030_vibra twl4030_charger industrialio w2sg0004 ehci_omap omapdss
>> [   52.995513] CPU: 0 PID: 2260 Comm: Xorg Not tainted 4.11.0-rc7-letux+ #1000
>> [   53.002838] Hardware name: Generic OMAP36xx (Flattened Device Tree)
>> [   53.009429] [<c010f378>] (unwind_backtrace) from [<c010b8fc>] (show_stack+0x10/0x14)
>> [   53.017578] [<c010b8fc>] (show_stack) from [<c043e180>] (dump_stack+0x98/0xd0)
>> [   53.025146] [<c043e180>] (dump_stack) from [<c012f4b8>] (__warn+0xd0/0x100)
>> [   53.032470] [<c012f4b8>] (__warn) from [<c012f58c>] (warn_slowpath_null+0x1c/0x24)
>> [   53.040496] [<c012f58c>] (warn_slowpath_null) from [<bf3b90e8>] (omap_gem_put_paddr+0x30/0x60 [omapdrm])
>> [   53.050659] [<bf3b90e8>] (omap_gem_put_paddr [omapdrm]) from [<bf3b80c4>] (omap_framebuffer_unpin+0x58/0x6c [omapdrm])
>> [   53.062103] [<bf3b80c4>] (omap_framebuffer_unpin [omapdrm]) from [<bf384468>] (drm_atomic_helper_cleanup_planes+0x48/0x50 [drm_kms_helper])
>> [   53.075378] [<bf384468>] (drm_atomic_helper_cleanup_planes [drm_kms_helper]) from [<bf3b5498>] (omap_atomic_complete+0x64/0xc4 [omapdrm])
>> [   53.088409] [<bf3b5498>] (omap_atomic_complete [omapdrm]) from [<bf3b5ea8>] (omap_atomic_commit+0x1bc/0x1e0 [omapdrm])
>> [   53.099731] [<bf3b5ea8>] (omap_atomic_commit [omapdrm]) from [<bf387c1c>] (drm_atomic_helper_set_config+0x50/0xa0 [drm_kms_helper])
>> [   53.112609] [<bf387c1c>] (drm_atomic_helper_set_config [drm_kms_helper]) from [<bf2ee1c0>] (drm_mode_set_config_internal+0x4c/0xcc [drm])
>> [   53.125976] [<bf2ee1c0>] (drm_mode_set_config_internal [drm]) from [<bf2ee928>] (drm_mode_setcrtc+0x354/0x430 [drm])
>> [   53.137359] [<bf2ee928>] (drm_mode_setcrtc [drm]) from [<bf2e7dfc>] (drm_ioctl+0x2f8/0x3c4 [drm])
>> [   53.146850] [<bf2e7dfc>] (drm_ioctl [drm]) from [<c0282e50>] (vfs_ioctl+0x20/0x34)
>> [   53.154785] [<c0282e50>] (vfs_ioctl) from [<c0283814>] (do_vfs_ioctl+0x82c/0x93c)
>> [   53.162597] [<c0283814>] (do_vfs_ioctl) from [<c0283970>] (SyS_ioctl+0x4c/0x74)
>> [   53.170288] [<c0283970>] (SyS_ioctl) from [<c0107040>] (ret_fast_syscall+0x0/0x1c)
>> [   53.375488] ---[ end trace b701f3dfb02e416c ]---
>> 
>> ...
> I have not seen them here (on a GTA04A5). Do you have any tiler patch on
> top of it?

Ah, yes. You are right.

> I think it comes from that one. I am testing without.

I have removed our private the TILER patches and the messages disappear.

Still interesting is that it can be triggered by some SyS_ioctl.

BR,
Nikolaus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20170420/7b5f5dac/attachment-0001.asc>


More information about the Letux-kernel mailing list