[Letux-kernel] regression: drm/omapdrm: Move commit_modeset_enables() before commit_planes()

[Adam Ford]

On Sat, Apr 15, 2017 at 2:44 AM, Andreas Kemnade <andreas at kemnade.info> wrote:
> Hi Jyri,
>
> I am often seeing only some moving horizontal white strips (maybe 1-2
> pixels thick) when I boot my gta04 (omap 3 dm3730 + panel_tpo_td028ttec1
> + encoder_opa362).
>

This is consistent with what I see in my Logic PD Torpedo board also a DM3730

> After a git bisect session, the verdict is: this patch is guilthy:
>
> commit 897145d0c7010b4e07fa9bc674b1dfb9a2c6fff9
> Author: Jyri Sarha <jsarha at ti.com>
>
>     drm/omapdrm: Move commit_modeset_enables() before commit_planes()
>
>
> dmesg output:
> [   58.580932] devm_usb_get_phy_by_node(ee69fc10 48070000.i2c:twl at 48:bci, ef7e63a4 twl4030-usb, ee7f1320)
> [   58.609344] twl4030-usb : hsusb2_phy
> [   58.613372] twl4030-usb : twl4030-usb
> [   58.617462] phy = ed083210
> [   58.630493] omapdss_dss 48050000.dss: 48050000.dss supply vdda_video not found, using dummy regulator
> [   58.648345] OMAP DSS rev 2.0
> [   58.652893] omapdss_dss 48050000.dss: bound 48050400.dispc (ops dispc_component_ops [omapdss])
> [   58.663543] omapdss_dss 48050000.dss: bound 48050c00.encoder (ops venc_component_ops [omapdss])
> [   58.674804] devm_usb_get_phy_by_node(ee69fc10 48070000.i2c:twl at 48:bci, ef7e63a4 twl4030-usb, ee7f1320)
> [   58.674835] twl4030-usb : hsusb2_phy
> [   58.674835] twl4030-usb : twl4030-usb
> [   58.674835] phy = ed083210
> [   58.698516] devm_usb_get_phy_by_node(ee69fc10 48070000.i2c:twl at 48:bci, ef7e63a4 twl4030-usb, ee7f1320)
> [   58.717620] twl4030-usb : hsusb2_phy
> [   58.721527] twl4030-usb : twl4030-usb
> [   58.725463] phy = ed083210
> [   58.837219] not all displays probed (0 of 2)
> [   58.878845] connector-analog-tv connector: failed to find video source
> [   58.920532] devm_usb_get_phy_by_node(ee69fc10 48070000.i2c:twl at 48:bci, ef7e63a4 twl4030-usb, ee7f1520)
> [   58.946228] twl4030-usb : hsusb2_phy
> [   58.950073] twl4030-usb : twl4030-usb
> [   58.954010] phy = ed083210
> [   58.988098] not all displays probed (1 of 2)
> [   58.994537] devm_usb_get_phy_by_node(ee69fc10 48070000.i2c:twl at 48:bci, ef7e63a4 twl4030-usb, ee7f1520)
> [   59.025512] twl4030-usb : hsusb2_phy
> [   59.029846] twl4030-usb : twl4030-usb
> [   59.033752] phy = ed083210
> [   59.082489] omapdrm omapdrm.0: DMM not available, disable DMM support
> [   59.092346] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
> [   59.100158] [drm] No driver support for vblank timestamp query.
> [   59.237670] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
> [   59.238525] Console: switching to colour frame buffer device 60x40
> [   59.241729] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004020
> [   59.241760] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004000
> [   59.241790] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004000
> [   59.241821] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004000
> [   59.241851] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004000
> [   59.241882] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004000
> [   59.241912] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004000
> [   59.241943] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004000
> [   59.241973] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004000
> [   59.350646] random: crng init done
> [   61.143005] omapdrm omapdrm.0: fb0: omapdrm frame buffer device
> [   64.139465] [drm] Initialized omapdrm 1.0.0 20110917 for omapdrm.0 on minor 0
> [   64.235809] omap_crtc_error_irq: 276178 callbacks suppressed
> [   64.251525] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004000
> [   64.268096] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
> [   64.284729] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
> [   64.301544] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
> [   64.318603] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
> [   64.335723] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
> [   64.352905] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
> [   64.370086] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
> [   64.387298] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
> [   64.404479] [drm:omap_crtc_error_irq] *ERROR* lcd: errors: 00004022
>
>
> related modules loaded:
> panel_tpo_td028ttec1 encoder_opa362 connector_analog_tv omapdrm
> drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt
> fb_sys_fops cfbcopyarea drm omapdss
>
> Note: this seems also to depend on initialisation timings. I have
> used a shell script as init to load the modules piece by piece.
>
> Regards,
> Andreas