[Letux-kernel] Upstream queue for GTA04 DT

[H. Nikolaus Schaller]

> Am 14.06.2016 um 21:08 schrieb Belisko Marek <marek.belisko at gmail.com>:
> 
> Hi Nikolaus,
> 
> On Tue, Jun 14, 2016 at 8:33 PM, H. Nikolaus Schaller <hns at goldelico.com> wrote:
>> Hi Marek,
>> some of your patches did arrive on linux-next and I have merged
>> them into letux-base and removed them the duplicates (not yet pushed - will combine with -rc4).
>> 
> OK I'll collect them and post them. I've fixed non-probed flash in
> 4.7-rc3 by commit:
> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi
> b/arch/arm/boot/dts/omap3-gta04.dtsi
> index 9e5a084..ddf3c46f 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> @@ -1120,10 +1120,7 @@
> };
> 
> &gpmc {
> -       ranges = <0 0 0x30000000 0x04>; /* CS0: NAND */
> -
>        nand at 0,0 {
> -               reg = <0 0 0>; /* CS0, offset 0 */
>                ti,nand-ecc-opt = "sw"; /* stay compatible with our
> old u-boot (does not support bch8) */
> 
>                kernel at 280000 {
> 
> Basically ranges was wrong which lead to strange errors in gpmc. I
> tested it and it works fine.

Does it read and write properly?

I have looked for the original commits for these changes:

<http://git.goldelico.com/?p=gta04-kernel.git;a=blobdiff;f=arch/arm/boot/dts/omap3-gta04.dtsi;h=1acc042d3e31fec183f43f97d7c9751ddaad1d93;hp=1c7ddb79e86919ffb6b1194f28a13418280d0925;hb=5f6dfbca3f2e937296ef23646353d73a724d3e87;hpb=3601120bc9318fa7d0c2a3aad2c520d5b6327450>

<http://git.goldelico.com/?p=gta04-kernel.git;a=blobdiff;f=arch/arm/boot/dts/omap3-gta04.dtsi;h=1c7ddb79e86919ffb6b1194f28a13418280d0925;hp=aef0351be1dfc04b5e0809401589193126944ed6;hb=3601120bc9318fa7d0c2a3aad2c520d5b6327450;hpb=0cfdade383c1699d4c4b1a0bbc2ded912fb7fe7b>

<http://git.goldelico.com/?p=gta04-kernel.git;a=commit;h=963807b515783414d1b2348babd6367e1a8f6432>

What I didn't find is where/why the range parts were modified.

Here they are only rearranged in the .dtsi file but already exist:

<http://git.goldelico.com/?p=gta04-kernel.git;a=blobdiff;f=arch/arm/boot/dts/omap3-gta04.dtsi;h=840a1f77155d60a6840a74fcc5afac9905819e3a;hp=034e1c2aecb42f78031bd5b59c8b81e2d880aa94;hb=270dc6c4;hpb=e809882fff0f3ac896e2f64e68bba63e4674be91>

Ah, I got it!!!

<http://git.goldelico.com/?p=gta04-kernel.git;h=e2c5eb7>

did add something we never got aware.

And the rearrangement re-substituted what *we* thought is correct by our commit 840a1f77155d60a6840a74fcc5afac9905819e3a

For some reason it did work (or we did not test deeply enough any more).

So please test if reading & writing of NAND works with your fixes.

> One minor issue: I again cannot push to
> kernel git (ask for password).

This is the key available to ssh:

AAAAB3NzaC1yc2EAAAADAQABAAABAQC7VdUjdlBLHeaJg7RUD6d0VZs7/81pHw9/XR0hWjEcgRShBqL+ua9rycZo1+15JX2fICP1vvkQ04wG2/Vd1wLwpud/NE3SvFEWTBRrQg5NAGF5isXPPQfEGCTDnHt5G49kFNwyO9/6yATakqamXVbmaB8Yb4dslm1msuaW1VlrRxyhMVewIf3f5Tzr3s2g8R+m/ihYFOlhLWtaBJKVQBmy2ygmVhHYofULeELn7IKX7+KnnAefQ0d68Xs9XrExqDbmyMW8vigxnB65rRGDD4Dg5LH7+3YNT2ZtpmBeDLuCzGsqRdagNpHwClFvZ8kCCr5TN8yR1tz0QpX9S4IatJUX marek.belisko at gmail.com

anything wrong with it?

> 
>> Two patches did not yet arrive in linux-next:
>> ARM: dts: omap3-gat04: Fix wifi handling
>> ARM: dts: omap3-gta04: Add missing pinmux for mcbsp4
>> 
>> BTW: it was ok to write status = "okay":
>> 
>> https://www.raspberrypi.org/documentation/configuration/device-tree.md -- section 1.4
>> 
>> Then I have looked through our gta04.dtsi for other things we can upstream.
>> The following fragments seem to be upstreamable for me:
>> 
>> 1.
>>        aliases {
>>                display1 = &tv0;
>>        };
>> 
>> 2.
>>        madc-hwmon {
>>                compatible = "ti,twl4030-madc-hwmon";
>>        };
>> 
>> 3.
>>        i2c1_pins:
>>        i2c2_pins:
>>        i2c3_pins:
>> 
>> 4.
>>        bmp085_pins:
>> 
>> 5.
>>        penirq_pins
>> 
>> 6.
>>        camera_pins: pinmux_camera_pins {
>> 
>> 7.
>> 
>> &twl_madc {
>>        ti,system-uses-second-madc-irq;
>> };
>> 
>> &twl_power {
>>        compatible = "ti,twl4030-power-reset";
>>        ti,use_poweroff;
>> };
>> 
>> 8.
>> /* spare */
>> &vmmc2 {
>>        regulator-min-microvolt = <1800000>;
>>        regulator-max-microvolt = <1800000>;
>> };
>> 
>> 9.
>> /* Needed to power the DPI pins */
>> 
>> &vpll2 {
>>        regulator-always-on;
>> };
>> 
>> This was some time ago suggested by Tomi Valkainen.
>> 
>> Big remaining tasks are only touchscreen, camera and all sound extensions...
>> 
>> BR,
>> Nikolaus
>> 
> 
> BR,
> 
> marek
> 
> -- 
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
> 
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> twitter: #opennandra
> web: http://open-nandra.com