[Letux-kernel] [PATCH 5/5] input: twl6040-vibra: remove mutex

Dmitry Torokhov dmitry.torokhov at gmail.com
Tue Apr 19 10:01:50 CEST 2016

On Tue, Apr 19, 2016 at 09:49:01AM +0200, H. Nikolaus Schaller wrote:
> > Am 18.04.2016 um 23:20 schrieb Dmitry Torokhov <dmitry.torokhov at gmail.com>:
> > 
> > On Mon, Apr 18, 2016 at 09:55:41PM +0200, H. Nikolaus Schaller wrote:
> >> The mutex does not seem to be needed.
> > 
> > twl6040_vibra_suspend() and vibra_play_work() may run concurrently, no?
> Hm. I don't know about the rule that would give an answer to this question...

Sorry, that was actually a statement, not really a question. It is
possible (although very unlikely) that userspace posts play request and
workqueue will not run until after suspend callback.

Thinking about it some more I wonder if we better do what
twl6040_vibra_close() does and cancel the work before shutting off the
device, so that there is no chance of work executing after suspend
callback and reenabling the device. This way we can indeed remove the



More information about the Letux-kernel mailing list