[Gta04-owner] wifi patches in letux-base?

[H. Nikolaus Schaller]

Am 23.01.2016 um 19:03 schrieb Andreas Kemnade <andreas at kemnade.info>:

> Hi,
> 
> On Sat, 23 Jan 2016 13:13:03 +0100
> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
> 
>> Hi,
>> 
>> Am 23.01.2016 um 11:36 schrieb Andreas Kemnade <andreas at kemnade.info>:
>> 
>>> Hi,
>>> 
>>> I found out that there is stuff in letux-base which is not upstreamed.
>>> Is everything there considered not upstreamable? What is considered a
>>> good fix and what not?
>> 
>> Well, some things in letux-base are purely historical and inherited from 3.7-neil...
>> So they might be wrong today.
>> 
> That is all 2013/2014. So it is not that historcal
> 
> $ git shortlog --no-merges v4.4...goldelico2/letux-base -- drivers/net/wireless/libertas 
> Dan Williams (1):
>      libertas/sdio: fix releasing memory twice.
> 
> H. Nikolaus Schaller (4):
>      [...] two patches and their reverts...
> NeilBrown (4):
>      libertas/sdio: make sure card enters power-off when firmware is loaded.
>      libertas - hack to fix suspend.
>      libertas/sdio: make power management dependant on MMC_CAP_POWER_OFF_CARD
>      libertas/sdio: simplify suspend/resume.
> 
> Why do we have a patch from the former libertas maintainers in letux-base and
> not upstream?! 

It indeed appears to be some mess... Needing housekeeping.
I would have to look into details to judge what and why it was merged.

Could have been attempts by Neil or Dan Williams that have been superseded
by official libertas code.

I really don't know if they are needed any more or are even a little harmful. At least,
they don't block operation completely.

>>> 
>>> The reason I ask is that there are some suspend problems I understand and
>>> that touches code which is modified in letux-base.
>> 
>> Well, if your code is better, we can remove all WiFi historical patches from
>> letux base and put yours on top (which is then the same as linus/master for this
>> subsystem).
>> 
> I am still analyzing. I will probably give these patches an extra review.
> I just wanted to know if it is known that we need to find 1000 users to fight
> 1000 gnomes or things like that for getting these things upstreamed ;-)

:)

BR,
Nikolaus