[Gta04-owner] [tip:irq/core] genirq: Don' t suspend nested_thread irqs over system suspend

tip-bot for NeilBrown tipbot at zytor.com
Mon May 18 17:27:31 CEST 2015

Commit-ID:  3c646f2c6aa9e918d7fc77867df7f430059f9ccc
Gitweb:     http://git.kernel.org/tip/3c646f2c6aa9e918d7fc77867df7f430059f9ccc
Author:     NeilBrown <neilb at suse.de>
AuthorDate: Sun, 17 May 2015 15:19:34 +1000
Committer:  Thomas Gleixner <tglx at linutronix.de>
CommitDate: Mon, 18 May 2015 17:23:47 +0200

genirq: Don't suspend nested_thread irqs over system suspend

Nested IRQs can only fire when the parent irq fires.  So when the
parent is suspended, there is no need to suspend the child irq.

Suspending nested irqs can cause a problem is they are suspended or
resumed in the wrong order.  If an interrupt fires while the parent is
active but the child is suspended, then the interrupt will not be
acknowledged properly and so an interrupt storm can result.  This is
particularly likely if the parent is resumed before the child, and the
interrupt was raised during suspend.

Ensuring correct ordering would be possible, but it is simpler to just
never suspend nested interrupts.

Signed-off-by: NeilBrown <neil at brown.name>
Cc: GTA04 owners <gta04-owner at goldelico.com>
Cc: Kalle Jokiniemi <kalle.jokiniemi at jollamobile.com>
Acked-by: Peter Zijlstra <peterz at infradead.org>
Cc: Rafael J. Wysocki <rjw at rjwysocki.net>
Link: http://lkml.kernel.org/r/20150517151934.2393e8f8@notabene.brown
Signed-off-by: Thomas Gleixner <tglx at linutronix.de>

 kernel/irq/pm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index 5204a6d..d22786a 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -123,6 +123,8 @@ void suspend_device_irqs(void)
 		unsigned long flags;
 		bool sync;
+		if (irq_settings_is_nested_thread(desc))
+			continue;
 		raw_spin_lock_irqsave(&desc->lock, flags);
 		sync = suspend_device_irq(desc, irq);
 		raw_spin_unlock_irqrestore(&desc->lock, flags);
@@ -163,6 +165,8 @@ static void resume_irqs(bool want_early)
 		if (!is_early && want_early)
+		if (irq_settings_is_nested_thread(desc))
+			continue;
 		raw_spin_lock_irqsave(&desc->lock, flags);
 		resume_irq(desc, irq);

More information about the Gta04-owner mailing list