[Gta04-owner] [PATCH 00/11] DTS updates for GTA04

NeilBrown neilb at suse.de
Tue Jan 6 19:58:24 CET 2015


On Mon, 5 Jan 2015 23:24:46 +0100 Belisko Marek <marek.belisko at gmail.com>
wrote:

> Hi Neil,
> 
> On Mon, Jan 5, 2015 at 8:59 PM, NeilBrown <neilb at suse.de> wrote:
> > Hi Marek,
> >  the following 11 patches fix some problems and add some enhancements
> >  in the GTA04 DTS file.  They all relate to features that are already
> >  supported by the upstream kernel. The patches apply to Linus'
> >  v3.19-rc2 kernel.
> Thanks for patches. I did check patches compared to existing in gta04
> kernel tree and some of patches are already present
> in that tree. Can you please ad to those patches: Signed-off-by: H.
> Nikolaus Schaller <hns at goldelico.com>
> All of them was done by Nikolaus.

No.  Those patches that I sent you were written by me.
It is very likely that Nikolaus has written identical patches.  If you would
rather send the patches that he wrote upstream I am perfectly happy with that.
> 
> Here is a list:
> Patch | git rev in gta04 kernel | Author
> 001 - 8d932e94 - H. Nikolaus Schaller
> 002 - 061f0323 - H. Nikolaus Schaller
> 005 - 061f0323 - H. Nikolaus Schaller
> 006 - c94de56f - H. Nikolaus Schaller
> 007 - d26794c0 - H. Nikolaus Schaller
> 008 - 58f0a3e8 - H. Nikolaus Schaller

This list very effectively shows what I don't like about this tree.

Only one of those patches is really ready to go upstream.  That is the last
one (58f0a3e8).  It was written in March 2014 and still hasn't been sent
upstream.
All all the rest (except d26794c0 which seems to be in the list by mistake)
are a mixture of different things with incomplete justification.  So they are
not ready of sending upstream.

Thanks,
NeilBrown


> 
> Thanks
> >
> >  There is one small change between these and the combined patch I sent
> >  earlier.  In that patch I had made a change to twl4030.dtsi.
> >  Changing that file in this series wasn't really appropriate and on
> >  further investigation it seemed best to configure twl-power entirely
> >  with omap3-gta04.dtsi, much like what omap3-beagle-xm.dts and other
> >  do.
> >
> >  If you are able to forward these upstream I would really appreciate
> >  it.
> >
> > Thanks,
> > NeilBrown
> >
> >
> > ---
> >
> > NeilBrown (11):
> >       ARM: dts: omap3-gta04: Fix backup-battery charging in devicetree file.
> >       ARM: dts: omap3-gta04: fix 'audio' support in dts file.
> >       ARM: dts: omap3-gta04: enable power-off for wifi card.
> >       ARM: dts: omap3-gta04: add support for sdio interrupts.
> >       ARM: dts: omap3-gta04: enable twl4030 vibra support.
> >       ARM: dts: omap3-gta04: add gyroscope
> >       ARM: dts: omap3-gta04: Fix a GPIO line.
> >       ARM: dts: omap3-gta04: enable power-off using twl4030.
> >       ARM: dts: omap3-gta04: only power DSS when necessary.
> >       ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"
> >       ARM: dts: omap3-gta04: Disable keypad
> >
> >
> >  arch/arm/boot/dts/omap3-gta04.dtsi |   78 +++++++++++++++++++++++++++++-------
> >  1 file changed, 63 insertions(+), 15 deletions(-)
> >
> > --
> > Signature
> >
> 
> BR,
> 
> marek
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.goldelico.com/pipermail/gta04-owner/attachments/20150107/21555002/attachment.asc>


More information about the Gta04-owner mailing list