[Gta04-owner] [PATCH 04/11] ARM: dts: omap3-gta04: add support for sdio interrupts.

[Belisko Marek]

Hi Neil,

On Mon, Jan 5, 2015 at 8:59 PM, NeilBrown <neilb at suse.de> wrote:
> From: NeilBrown <neil at brown.name>
>
> We need to arrange for the DAT1 line to become GPIO
> when the mmc host is asleep, so interrupts can wake
> the device.
>
> Signed-off-by: NeilBrown <neil at brown.name>
> ---
>  arch/arm/boot/dts/omap3-gta04.dtsi |   25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> index 8cfc54c44f83..803be76746e0 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> @@ -134,6 +134,26 @@
>                 >;
>         };
>
> +       mmc2_pins: pinmux_mmc2_pins {
> +               pinctrl-single,pins = <
> +                       OMAP3_CORE1_IOPAD(0x2158, PIN_INPUT_PULLUP | MUX_MODE0)         /* sdmmc2_clk */
> +                       OMAP3_CORE1_IOPAD(0x215a, PIN_INPUT_PULLUP | MUX_MODE0)         /* sdmmc2_cmd */
> +                       OMAP3_CORE1_IOPAD(0x215c, PIN_INPUT_PULLUP | MUX_MODE0)         /* sdmmc2_dat0 */
> +                       OMAP3_CORE1_IOPAD(0x215e, PIN_INPUT_PULLUP | MUX_MODE0)         /* sdmmc2_dat1 */
> +                       OMAP3_CORE1_IOPAD(0x2160, PIN_INPUT_PULLUP | MUX_MODE0)         /* sdmmc2_dat2 */
> +                       OMAP3_CORE1_IOPAD(0x2162, PIN_INPUT_PULLUP | MUX_MODE0)         /* sdmmc2_dat3 */
> +                       OMAP3_CORE1_IOPAD(0x2164, PIN_INPUT_PULLUP | MUX_MODE1)         /* sdmmc2_dir_dat0 */
> +                       OMAP3_CORE1_IOPAD(0x2166, PIN_INPUT_PULLUP | MUX_MODE1)         /* sdmmc2_dir_dat1 */
> +                       OMAP3_CORE1_IOPAD(0x2168, PIN_INPUT_PULLUP | MUX_MODE1)         /* sdmmc2_cmd */
> +                       OMAP3_CORE1_IOPAD(0x216a, PIN_INPUT_PULLUP | MUX_MODE1)         /* sdmmc2_clkin */
> +               >;
> +       };
blank line should be here
> +       mmc2_cirq_pin: pinmux_cirq_pin {
> +               pinctrl-single,pins = <
> +                       OMAP3_CORE1_IOPAD(0x215e, PIN_INPUT_PULLUP | MUX_MODE4)         /* sdmmc2_dat1 as GPIO_133 GPIO5,5 */
^^^^ this part of comment isn't necessary
> +               >;
> +       };
> +
>         dss_dpi_pins: pinmux_dss_dpi_pins {
>                 pinctrl-single,pins = <
>                         OMAP3_CORE1_IOPAD(0x20d4, PIN_OUTPUT | MUX_MODE0)   /* dss_pclk.dss_pclk */
> @@ -321,6 +341,11 @@
>         bus-width = <4>;
>         ti,non-removable;
>         cap-power-off-card;
> +       interrupts-extended = <&intc 86 &gpio5 5 0>; /* GPIO_133 */
> +       pinctrl-names = "default", "active", "idle";
states names are invalid. should be : "default", "idle", "sleep"
(definitions in include/linux/pinctrl/pinctrl-state.h)
> +       pinctrl-0 = <&mmc2_pins>;
> +       pinctrl-1 = <&mmc2_pins>;
> +       pinctrl-2 = <&mmc2_cirq_pin>;
>  };
>
>  &mmc3 {
>
>
Did you try to test it? (something like put system to sleep and wake
it by WOW packet?)

Thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com