[Gta04-owner] Kernel 3.7 extensions

Dr. H. Nikolaus Schaller hns at goldelico.com
Mon Jan 28 11:13:32 CET 2013


Am 28.01.2013 um 11:07 schrieb NeilBrown:

> On Mon, 28 Jan 2013 10:29:50 +0100 "Dr. H. Nikolaus Schaller"
> <hns at goldelico.com> wrote:
> 
>> Hi Neil,
>> I am working to add many nice features the hw-validation kernel already
>> has (like tv-out, missing sensors, camera, pvr, display panel support for 3704,
>> 7004 device variants and some minor things required mostly for hardware
>> tests) to the 3.7 kernel.
>> 
>> One piece of code isn't clear to me:
>> 
>> #ifdef CONFIG_TOUCHSCREEN_TSC2007
>> 	tsc2007_boardinfo.irq = gpio_to_irq(TS_PENIRQ_GPIO);
>> 	i2c_register_board_info(2, &tsc2007_boardinfo, 1);
>> #endif
>> #ifdef CONFIG_BMP085
>> 	i2c_register_board_info(2, &bmp085_boardinfo, 1);
>> #endif
>> 
> 	omap_register_i2c_bus(2, 400,  gta04_i2c2_boardinfo,
>> 				ARRAY_SIZE(gta04_i2c2_boardinfo));
>> 
>> Was there a specific reason to register those two devices
>> separately and not simply have them listed in gta04_i2c2_boardinfo[]?
>> 
> 
> Not a good one.
> It was a long time ago, but I think I probably did it because of the need to
> set the 'irq' to a non-constant.  I didn't really understand all the code at
> the time and probably copied something from somewhere without thinking it
> though.
> 
> It certainly looks as though it should be fine to leave them in
> gta04_i2c2_boardinfo, just as long as the irq line is set properly before
> omap_register_i2c_bus() is called.

Ok!

Then, I'll change it that way (like it is done in the old hw-validation).

Next question will come soon :)

BR,
Nikolaus



More information about the Gta04-owner mailing list