[Gta04-owner] [PATCH] gta04-voice: fix gtm601 registration order

Robert Schwebel r.schwebel at pengutronix.de
Mon Sep 5 21:43:46 CEST 2011


On Mon, Sep 05, 2011 at 09:37:13PM +0200, Dr. H. Nikolaus Schaller wrote:
> > On 2011-09-05, John Ogness <gta04 at ogness.net> wrote:
> >> You are correct. I registered the platform device in my machine file
> >> and it also works. The problem doesn't appear to be in the
> >> sound/codec/alsa code.
> > 
> > OK. Now I can reproduce your crash. My gtm601.c code wasn't the latest
> > version. It seems the changes to the gtm601.c file in the commits:
> > 
> > 0fc9f0f41e9b700f563209e5deed7f89ba350962
> > a0c995cb459e6df3928b6f155b6d44c57b9c1602
> > 
> > broke the gtm601 driver.
> > 
> > If you remove the changes to the file, it should bind correctly.
> 
> I see - there was something messed up and I don't see exactly
> how to restore it and to which state.
> 
> The easiest way would be that you send me a copy of your
> gtm601.c files.

If the above commits are the cause for the breakage and you just want to
revert them, use

$ git revert 0fc9f0f41e9b700f563209e5deed7f89ba350962 a0c995cb459e6df3928b6f155b6d44c57b9c1602

However, I havn't looked at the code, so if you only want to revert
parts of that change, you'll probably have to do that manually.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


More information about the Gta04-owner mailing list