[Gta04-owner] Linux 3.2-rc4 - now with wifi

[NeilBrown]

On Fri, 09 Dec 2011 17:03:04 +0100 Lukas Märdian
<lukasmaerdian at googlemail.com> wrote:

> On 03.12.2011 06:31, NeilBrown wrote:
> > 
> > hi all,
> > 
> >  I've updated my mainline gta04 kernel tree to 3.2-rc4.
> >     git://neil.brown.name/gta04 merge
> > 
> > 
> > The main new functionality is wireless.  The details for enabling wireless
> > are slightly different than with the hw-validation kernel.
> > 
> > 1/ the reset line is /sys/class/gpio/gta04:wlan:reset
> >     write 0 to reset, 1 to release the reset
> >    The "reset" line is active-low.
> > 
> > 2/ After power-on and reset you need to trigger a card-detect signal.
> >    This requires making gpio/gta:wlan/cd go high, then low.  Card-detect
> >    is active-low too.
> > 
> 
> Hey Neil,
> 
> I probably discovered a bug in your code, while trying to compile this
> kernel with openembedded.
> 
> I was using an older defconfig, which didn't have the option
> CONFIG_LEDS_TCA6507 set.
> 
> This caused the following error:
> 
> arch/arm/mach-omap2/board-omap3gta04.c: In function 'inout_setup_gpio':
> arch/arm/mach-omap2/board-omap3gta04.c:802:15: error: 'GPIO_WIFI_RESET'
> undeclared (first use in this function)
> arch/arm/mach-omap2/board-omap3gta04.c:802:15: note: each undeclared
> identifier is reported only once for each function it appears in
> arch/arm/mach-omap2/board-omap3gta04.c: At top level:
> arch/arm/mach-omap2/board-omap3gta04.c:811:15: error: 'GPIO_WIFI_RESET'
> undeclared here (not in a function)
> arch/arm/mach-omap2/board-omap3gta04.c:211:31: warning:
> 'gta04_dvi_device' defined but not used [-Wunused-variable]
> arch/arm/mach-omap2/board-omap3gta04.c:317:31: warning:
> 'gta04_tv_device' defined but not used [-Wunused-variable]
> make[1]: *** [arch/arm/mach-omap2/board-omap3gta04.o] Error 1
> 
> You're using GPIO_WIFI_RESET, which could potentially not be set.
> I don't have a patch at hand, as I'm a kernel novice, but i guess this
> could easily be fixed.

Probably it could, but I don't think I'll bother.

I don't think there is a lot of point in building a kernel for the GTA04
without the LEDS_TCA6507 driver as then the leds and the wifi won't work.
So the compile error is useful as it tells you that the kernel won't
work :-)

Also, I don't think the board-omap3gta04.c file will ever go upstream.  The
arm community is working towards describing boards using "device tree" rather
than board files.  So making this file clean and perfect is not worth the
effort (making it a bit more readable probably is and I'll probably clean
some bits of it up).

So yes - it could be fixed, but I really don't think it is worth any effort.

Thanks for the report though.

NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: not available
URL: <http://lists.goldelico.com/pipermail/gta04-owner/attachments/20111211/ba5fcff3/attachment.bin>