<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Anthoine,<div class="">thanks for your patch set.</div><div class=""><br class=""></div><div class="">It seems to be a little in conflict with:</div><div class=""><br class=""></div><div class=""><a href="https://git.goldelico.com/?p=letux-kernel.git;a=blobdiff;f=drivers/gpu/drm/pvrsgx/1.17.4948957/eurasia_km/services4/srvkm/env/linux/osfunc.c;h=363563867ea93929fac82a994125152915b17062;hp=703ebe16395841183df6289e4ae4caa5d906e903;hb=063ffd2f333104dcd6ee8ed8e060274ba81015a5;hpb=27b24edbb990a4ec337a54939560e6749951a743" class="">https://git.goldelico.com/?p=letux-kernel.git;a=blobdiff;f=drivers/gpu/drm/pvrsgx/1.17.4948957/eurasia_km/services4/srvkm/env/linux/osfunc.c;h=363563867ea93929fac82a994125152915b17062;hp=703ebe16395841183df6289e4ae4caa5d906e903;hb=063ffd2f333104dcd6ee8ed8e060274ba81015a5;hpb=27b24edbb990a4ec337a54939560e6749951a743</a></div><div class=""><br class=""></div><div class="">but is certainly an improvement since it adds the correct LINUX_VERSION_CODE check.</div><div class=""><br class=""></div><div class="">So we have to think about making the best out of the two commits... E.g. include my rationale for the patch ("<span style="font-family: monospace; font-size: small; background-color: rgb(255, 255, 255);" class="">arm_dma_ops. are no longer accessible.")</span></div><div class=""><br class=""></div><div class="">Doing the same for the DDK 1.14 (your PATCH 2/2) seems to be correct. I just did not compile that one and therefore have missed it.</div><div class=""><br class=""></div><div class="">BR and thanks,</div><div class="">Nikolaus</div><div class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Am 08.09.2022 um 17:01 schrieb Anthoine Bourgeois <<a href="mailto:anthoine.bourgeois@gmail.com" class="">anthoine.bourgeois@gmail.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><div class="">Signed-off-by: Anthoine Bourgeois <<a href="mailto:anthoine.bourgeois@gmail.com" class="">anthoine.bourgeois@gmail.com</a>><br class="">---<br class=""> .../eurasia_km/services4/srvkm/env/linux/osfunc.c | 6 +++---<br class=""> 1 file changed, 3 insertions(+), 3 deletions(-)<br class=""><br class="">diff --git a/drivers/gpu/drm/pvrsgx/1.17.4948957/eurasia_km/services4/srvkm/env/linux/osfunc.c b/drivers/gpu/drm/pvrsgx/1.17.4948957/eurasia_km/services4/srvkm/env/linux/osfunc.c<br class="">index 703ebe163958..c6c1b1f43155 100644<br class="">--- a/drivers/gpu/drm/pvrsgx/1.17.4948957/eurasia_km/services4/srvkm/env/linux/osfunc.c<br class="">+++ b/drivers/gpu/drm/pvrsgx/1.17.4948957/eurasia_km/services4/srvkm/env/linux/osfunc.c<br class="">@@ -4563,7 +4563,7 @@ static void pvr_dmac_clean_range(const void *pvStart, const void *pvEnd)<br class=""><br class=""> static void pvr_flush_range(phys_addr_t pStart, phys_addr_t pEnd)<br class=""> {<br class="">-#if defined(__aarch64__)<br class="">+#if defined(__aarch64__) || (LINUX_VERSION_CODE >= KERNEL_VERSION(6,0,0))<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>struct device *dev = PVRLDMGetDevice();<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>dma_sync_single_for_device(dev, pStart, pEnd - pStart, DMA_TO_DEVICE);<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>dma_sync_single_for_cpu(dev, pStart, pEnd - pStart, DMA_FROM_DEVICE);<br class="">@@ -4575,7 +4575,7 @@ static void pvr_flush_range(phys_addr_t pStart, phys_addr_t pEnd)<br class=""><br class=""> static void pvr_clean_range(phys_addr_t pStart, phys_addr_t pEnd)<br class=""> {<br class="">-#if defined(__aarch64__)<br class="">+#if defined(__aarch64__) || (LINUX_VERSION_CODE >= KERNEL_VERSION(6,0,0))<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>struct device *dev = PVRLDMGetDevice();<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>dma_sync_single_for_device(dev, pStart, pEnd - pStart, DMA_TO_DEVICE);<br class=""> #else<br class="">@@ -4586,7 +4586,7 @@ static void pvr_clean_range(phys_addr_t pStart, phys_addr_t pEnd)<br class=""><br class=""> static void pvr_invalidate_range(phys_addr_t pStart, phys_addr_t pEnd)<br class=""> {<br class="">-#if defined(__aarch64__)<br class="">+#if defined(__aarch64__) || (LINUX_VERSION_CODE >= KERNEL_VERSION(6,0,0))<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>struct device *dev = PVRLDMGetDevice();<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>dma_sync_single_for_cpu(dev, pStart, pEnd - pStart, DMA_FROM_DEVICE);<br class=""> #else<br class="">-- <br class="">2.35.1<br class=""><br class=""></div></div></blockquote></div><br class=""></div></body></html>