<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Looks Good to me as well. I will pick up asap into the repos.<br><br><div dir="ltr">On<span style="font-size: 13pt;"> The Road</span></div><div dir="ltr"><br><blockquote type="cite">Am 10.06.2020 um 16:58 schrieb Tony Lindgren <tony@atomide.com>:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><span>* David Shah <dave@ds0.me> [200610 14:06]:</span><br><blockquote type="cite"><span>A missing call to PVRSRVRelease means that dmabufs are leaked by the</span><br></blockquote><blockquote type="cite"><span>driver, particularly if applications aren't closed properly. This was</span><br></blockquote><blockquote type="cite"><span>particularly noticeable with TILER due to the limited TILER space and</span><br></blockquote><blockquote type="cite"><span>current 8192-wide allocations.</span><br></blockquote><span></span><br><span>Sorry for missing this part, I was mostly playing with ddk-1.9 that</span><br><span>proxies all the ioctls via omapdrm so it has a slightly different</span><br><span>release path.</span><br><span></span><br><span>Looks like for the ddk-1.9 droid4 related patches I needed a similar</span><br><span>release for omapdrm set with plugin.release = pvr_omap4_release. It</span><br><span>gets called by omapdrm in that case. Just FYI, does not affect this</span><br><span>patch.</span><br><span></span><br><span>Thanks for fixing the issue, this patch looks good to me:</span><br><span></span><br><span>Acked-by: Tony Lindgren <tony@atomide.com></span><br><span>_______________________________________________</span><br><span>https://github.com/openpvrsgx-devgroup/linux_openpvrsgx</span><br><span>openpvrsgx-devgroup mailing list</span><br><span>openpvrsgx-devgroup@letux.org</span><br><span>http://lists.goldelico.com/mailman/listinfo.cgi/openpvrsgx-devgroup</span><br></div></blockquote></body></html>