<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class="">yes, the ADC driver is inaccurate. It should be fixed and not disabled in DTS.</div><div class=""><div class="">To disable a broken driver, there is a better method which is IMHO already added to the latest Pyra kernels. It is</div><div class=""><br class=""></div><div class="">echo blacklist generic-adc-battery >>/etc/modprobe.d/gab.conf</div><div class=""><br class=""></div><div class="">or similar.</div><div class=""><br class=""></div><div class="">Having different DTS is IMHO not the right strategy.</div><div class=""><br class=""></div><div class="">BR and thanks,</div><div class="">Nikolaus</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">Am 06.08.2020 um 18:09 schrieb Nick Elsmore <<a href="mailto:nicholaselsmore@gmail.com" class="">nicholaselsmore@gmail.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">ADC battery driver provides extra inaccurate battery information which confuses userspace tools. We should just get this information from the bq27xx/bq24xx combo.<br class=""></div><div class=""><br class=""></div><div class="">Signed-off-by: Nick Elsmore <<a href="mailto:nicholaselsmore@gmail.com" class="">nicholaselsmore@gmail.com</a>></div><div class="">---<br class=""> arch/arm/boot/dts/pyra-mainboard-common.dtsi | 24 --------------------<br class=""> 1 file changed, 24 deletions(-)<br class=""><br class="">diff --git a/arch/arm/boot/dts/pyra-mainboard-common.dtsi b/arch/arm/boot/dts/pyra-mainboard-common.dtsi<br class="">index 67aca9b084de..b06fb6c12143 100644<br class="">--- a/arch/arm/boot/dts/pyra-mainboard-common.dtsi<br class="">+++ b/arch/arm/boot/dts/pyra-mainboard-common.dtsi<br class="">@@ -815,27 +815,3 @@ &wlcore {<br class=""> compatible = "ti,wl1837";<br class=""> };<br class=""> <br class="">-<br class="">-/* was #include <dt-bindings/power/power.h> */<br class="">-<br class="">-#define POWER_SUPPLY_TECHNOLOGY_NiMH 1<br class="">-#define POWER_SUPPLY_TECHNOLOGY_LION 2<br class="">-#define POWER_SUPPLY_TECHNOLOGY_LIPO 3<br class="">-#define POWER_SUPPLY_TECHNOLOGY_LiFe 4<br class="">-#define POWER_SUPPLY_TECHNOLOGY_NiCd 5<br class="">-#define POWER_SUPPLY_TECHNOLOGY_LiMn 6<br class="">-<br class="">-/ {<br class="">- battery: battery-monitor {<br class="">- compatible = "linux,generic-adc-battery";<br class="">- io-channels = <&gpadc 6>, <&gpadc 11>, <&gpadc 1>;<br class="">- io-channel-names = "voltage", "current", "temperature";<br class="">- monitored-battery = <&bat>;<br class="">- technology = <POWER_SUPPLY_TECHNOLOGY_LION>;<br class="">- battery-name = "pyra-battery";<br class="">- charge_full_design = <6000000>;<br class="">- charge_empty_design = <00>;<br class="">- voltage_min_design = <3200000>;<br class="">- voltage_max_design = <4200000>;<br class="">- };<br class="">-};<br class="">-- <br class="">2.25.1<br class=""></div></div>
_______________________________________________<br class=""><a href="https://projects.goldelico.com/p/gta04-kernel/" class="">https://projects.goldelico.com/p/gta04-kernel/</a><br class="">Letux-kernel mailing list<br class="">Letux-kernel@openphoenux.org<br class="">http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel<br class=""></div></blockquote></div><br class=""></div></div></body></html>