[Letux-kernel] Upstreaming some CI20/JZ4780 patches

H. Nikolaus Schaller hns at goldelico.com
Tue Feb 11 22:32:33 CET 2020


Hi Paul,

> Am 11.02.2020 um 21:20 schrieb Paul Boddie <paul at boddie.org.uk>:
> 
> On Tuesday 11. February 2020 18.07.59 you wrote:
>> Hi Paul,
>> I have now rebased everything to v5.6-rc1 and sorted/reworked/checkpatched
>> some of our commits to prepare for submission to LKML.
>> 
>> Rebasing did only touch some small areas of our JZ4730 support.
> 
> I can imagine revisiting that at some point, but not particularly soon.
> 
>> Please check the CI20 result with:
>> 
>> 	http://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux/ci20-minimal
> 
> I'll try and do so.
> 
>> The plan is to submit only
>> 
>> 940759f2eef8 MIPS: CI20: defconfig: configure for CONFIG_KEYBOARD_GPIO=m
>> 8532dbf0d74f MIPS: DTS: CI20: add DT node for SW1 as Enter button
>> 19177b5cd1f9 MIPS: CI20: defconfig: compile gpio-ir driver
>> 92268cd8ab4f MIPS: DTS: CI20: add DT node for IR sensor
>> 5e866ca81548 MIPS: CI20: defconfig: configure CONFIG_REGULATOR_ACT8865 for
>> PMU
>> 092eb743b150 MIPS: DTS: CI20: fix PMU definitions for ACT8600
>> 8203cadea84e MIPS: CI20: defconfig: compile leds-gpio driver into the kernel
>> and configure for LED triggers
>> 1f1b0569ef41 MIPS: CI20: defconfig: configure for supporting modules
>> 1f36b92b6b4f MIPS: DTS: jz4780: fix #includes for irq.h and gpio.h
>> eb780d828f62 net: davicom: dm9000: allow to pass MAC address through
>> mac_addr module parameter
>> e6c03d1f824f pinctrl: ingenic: add hdmi-ddc pin control group
>> 028ea3e94885 drm: ingenic-drm: add MODULE_DEVICE_TABLE
>> 3197c735966d i2c: jz4780: suppress txabrt reports for i2cdetect
>> 
>> in a first phase.
> 
> I think the above are pretty sensible and not particularly controversial.
> 
>> This leaves our "poweroff" fixes for a second submission since I think we
>> should have working "reboot" as well.
> 
> Yes, this is more difficult to test, and rebooting needs to be reviewed.
> 
>> A third RFC submission will be HDMI stuff. It depends a little on the PMU
>> fixes pushed in the first phase. But I have already included the hdmi-ddc
>> pin configs in the first step.
> 
> I think it is a wise plan. In principle, the hdmi-ddc mechanism isn't really 
> needed, but it seems to work without the I2C peripheral complications.
> 
>> So the plan is to fight the acceptance of the patches mentioned above first,
>> then do separate RFCs for HDMI and RTC/poweroff.
>> 
>> I think there is only one patch authored by you in the first patch set,
>> which is missing a Signed Off:
>> 
>> pinctrl: ingenic: add hdmi-ddc pin control group
>> 
>> 	http://git.goldelico.com/?p=letux-kernel.git;a=commit;h=e6c03d1f824f8ade86015dbcc6843c4f3ec59e6c
>> 
>> Please confirm that I can add your Signed Off.
> 
> Yes, you may!
> 
> Should we also include a ci20.dts device tree patch incorporating the 
> following pinctrl details...?
> 
>        pins_hdmi_ddc: hdmi_ddc {
>                function = "hdmi-ddc";
>                groups = "hdmi-ddc";
>                bias-disable;
>        };
> 
> It probably belongs with the pinctrl driver changes.

Yes, indeed.

Hm. On the other hand people may ask why we just submit this and not
a full HDMI setup which refers to pins_hdmi_ddc. I.e. the pin control
alone isn't of much use.

So I think we should better group the pinctrl: ingenic: add hdmi-ddc pin control group
to the HDMI stuff.

BR and thanks,
Nikolaus



More information about the Letux-kernel mailing list