[Letux-kernel] [RFC PATCH 0/3] Enable 1GHz support on omap36xx

Adam Ford aford173 at gmail.com
Mon Sep 2 23:10:30 CEST 2019


On Mon, Sep 2, 2019 at 10:46 AM H. Nikolaus Schaller <hns at goldelico.com> wrote:
>
> Hi Adam,
>
> > Am 02.09.2019 um 13:37 schrieb Adam Ford <aford173 at gmail.com>:
> >
> >> We have to define opp-v2 tables and add some config and code to the ti-cpufreq
> >> driver which reads out the silicon revision and eFuse registers. And we have
> >> to blacklist the chips in the cpufreq-dt-platdev driver.
> >>
> >> Reading the eFuse registers in the ti-cpufreq code is tricky since they are not part
> >> of the syscon register block like on am33xx or dra7. I have added some ioremap()
> >> and readl(). It works, but it can be improved in future work if someone has
> >> a better idea. For the moment I would consider it as a simple and good enough
> >> solution.
> >
> > I looked into this once, but I struggled with understanding how the
> > driver worked.
>
> Yes, It did take me quite some trial and error and trying to find what is
> common in the different data sheets and TRMs and how to make sense out of
> the masks and bit shifts...
>
> But my tests show that decoding works now. So you already might give it a try.

I am traveling all this week, but I have an omap3530, DM3730
(omap3630), and an AM3517 that I use for testing.

>
> >> I have also tried to add the same approach for the 600/720MHz speed grades of
> >> the omap3430 but have not found a BeagleBoard C4 which should have the 720MHz
> >> grade. The C2 I have tested with has 600MHz only.
> >>
> >> Note that omap3430 and omap3630 have different OPPs so we can not share
> >> tables.
> >>
> >> Another complication is that the DTS have no uniform compatible= records for
> >> the 34xx. I have found e.g.:
> >>
> >> omap3-beagle.dts:       compatible = "ti,omap3-beagle", "ti,omap3";
> >> omap3-cm-t3530.dts:     compatible = "compulab,omap3-cm-t3530", "ti,omap34xx", "ti,omap3";
> >> omap3-evm.dts:          compatible = "ti,omap3-evm", "ti,omap3430", "ti,omap3";
> >> omap3-sbc-t3517.dts:    compatible = "compulab,omap3-sbc-t3517", "compulab,omap3-cm-t3517", "ti,am3517", "ti,omap3";
> >
> > Based on my screening of the device trees, it seems like 34xx is
> > appropriate for most OMAP3's which are not am3517 and not omap36xx.
>
> Fine!
>
> > The AM3517 includes omap3.dtsi, but not all 34xx devices.  I think if
> > that was the case, they would have merged them.  The omap36xx have
> > some different register addresses from 34xx which I think why both
> > 34xx and 36xx (and am3517) all include what they can from the
> > omap3.dtsi stuff.  Even the clocks vary between 34xx, AM35 and omap36.
>
> Yes, the am3517/3503 is a Sitara processor and seems to be derived
> from omap35xx, some time before the am33xx was designed. So it appears
> to be a mix of everything.
>
> >>
> >> But all ti,omap36xx also have ti,omap3.
> >>
> >> So there is "omap3430", "omap34xx" or no definition (or even "ti,am3517").
> >
> > I don't believe AM3517 have different OPPs.  I looked through the
> > datasheet and didn't find any.
>
> Yes, according to the data sheet it has constant core operation voltage
> of 1.2V (1.152 .. 1.20 .. 1.248). So there seem to be no explicit operation
> points depending on core frequency. External clock/xtal is fixed 26 MHz.
> There seems to be no definition of ARM clock except max. 600 MHz and
> a hint of 500 MHz clock for device operation POH.
>
> > At one time I tried to run the AM3517
> > at various frequencies based on the 3430 frequency points, but the
> > operating voltage appears to be fixed.
>
> So this means we have to make sure the there is no opp table for
> the am3517. And no cpufreq driver being loaded. Which makes me think
> that it is simply running at the clock rate defined by SPL/U-boot.
>
> Or a table with different clock frequency points but constant voltage
> of 1200mV could be added.

I tried that once, and it worked, but since the datasheet didn't
specify it, I was worried it might violate some rules, but I did see
power reductions.

>
> > To me, it seems like it would make sense to standardize on the naming
> > convention. (ie, make omap34xx boards and omap35xx boards, explictly
> > state omap34xx, excluding the am35xx unless we want add extra stuff
> > for it)
>
> Yes, seems to be reasonable and a scheme could be:
>
> omap3.dtsi      "ti,omap3430", "ti,omap3"                       no opp table
> omap34xx.dtsi   inherited                                       opp table for omap34xx  #includes omap3.dtsi
> omap36xx.dtsi   inherited                                       opp table for omap36xx  #includes omap3.dtsi
>
> am3517 board    "boardname", "ti,am3517", "ti,omap3"            no opp table            #includes omap3.dtsi
> omap34xx board  "boardname", "ti,omap34xx", "ti,omap3"          opp table for omap34xx  #includes omap34xx.dtsi
> omap36xx board  "boardname", "ti,omap36xx", "ti,omap3"          opp table for omap34xx  #includes omap36xx.dtsi

I like that.
>
> So this means that only boards define either "ti,omap34xx" or "ti,omap36xx" (or neither)
> which makes the ti-cpufreq driver match.
>
> >> This makes matching the ti-cpufreq driver for either omap34xx or omap36xx difficult...
> >
> > If we add omap34xx to all non-36xx boards and non-am35xx boads, the
> > the check for the compatible flag in the ti-cpufreq driver be based on
> > looking for "ti,34xx" and "ti,36xx" .
>
> That is what I also would prefer :)

Thanks for doing all this work.  As soon as I come back from
traveling, I will test on all 3 boards  and take power measurements.
>
> So I'll add more patches like the one for omap3-beagle.dts for all boards I can
> find and try to verify that it does not interfere with the am3517.
>
> >>
> >> Finally, I am not exactly sure about if omap3430 and omap3530 are really the
> >> same for the eFuses and silicon revision registers and values...
> >
> > From what I can tell they are, but hopefully someone from TI can confirm.
>

adam
> BR,
> Nikolaus
>


More information about the Letux-kernel mailing list