[Letux-kernel] Pyra display driver once again broken in v5.2-rc1

H. Nikolaus Schaller hns at goldelico.com
Thu May 30 12:46:09 CEST 2019


> Am 29.05.2019 um 20:38 schrieb Andreas Kemnade <andreas at kemnade.info>:
> 
> On Wed, 29 May 2019 06:39:22 +0200
> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
> 
>>> Am 28.05.2019 um 23:40 schrieb Andreas Kemnade <andreas at kemnade.info>:
>>> 
>>> On Mon, 27 May 2019 21:25:41 +0200
>>> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
>>> 
>>>>> Am 27.05.2019 um 14:46 schrieb H. Nikolaus Schaller <hns at goldelico.com>:
>>>>> 
>>>>> Hi,
>>>>> unfortunately every year or so some upstream change breaks
>>>>> our (still out-of tree) DSI panel driver for the Pyra(Phone).
>>>>> This time it happened with v5.2-rc1.
>>>>> 
>>>>> v5.2-rc1 also broke the GTA04 display and the L3704/L7004 displays,
>>>>> but those are DPI panels and the reasons were two separate
>>>>> issues which have nothing to do with the Pyra DSI panel.
>>>>> 
>>>>> There have been some API changes for DSI panel drivers and
>>>>> I have done a
>>>>> 
>>>>> 	git diff v5.2-rc1 v5.1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
>>>>> 
>>>>> to identify them and tried to apply similar patches to our
>>>>> panel. But still the driver is successfully probed, but shows
>>>>> not activity. No calls to enable() or connect(). Backlight stays
>>>>> black. And as a result there is also no /dev/fb0, text console
>>>>> or X11.
>>>>> 
>>>>> Unfortunately, it has not improved after upgrading to v5.2-rc2.
>>>>> 
>>>>> So once again it appears that I have to git bisect upstream
>>>>> patches to find out what is going on...    
>>>> 
>>>> After spending more hours... it does not seem to be in our patches
>>>> and the panel driver is likely almost correct now.
>>>> 
>>>> I believe this because I also found not working:
>>>> * dwc3 (usb3/otg port)
>>>> * bq24297 battery charger driver (my Pyra fortunately runs well enough with U-Boot initialization)
>>>> * tca6424 (gpio expander - we use the pcal9524 variant)
>>>> 
>>>> The tca6424 driver seems to be broken (not loaded).
>>>> 
>>> [    6.581432] ts3a227e 4-003b: Cannot request irq 0 (-22)
>>> [    6.597252] ts3a227e: probe of 4-003b failed with error -22
>>> 
>>> so somehow it insists of having an irq and we are not providing one in
>>> the dtb, at least not in pyra-mainboard-v5.1.dtsi  
>> 
>> The reference is set in pyra-mainboard-v5.2.dtsi
>> 
>> 		interrupt-parent = <&gpio99>;
>> 		interrupts = <14 IRQ_TYPE_EDGE_RISING>;
>> 
>> But: this is another symptom of the tca6424 (gpio99) not being available.
>> It is not only a gpio expander but also an interrupt expander.
>> 
> after disabling that invert write I see
> still
> root at letux:~# dmesg | grep ts3a
> [    6.913371] ts3a227e 4-003b: Cannot request irq 0 (-22)
> [    6.932368] ts3a227e: probe of 4-003b failed with error -22
> 
> so it is an indepandant problem an least on board 5.1. It might work on
> board version 5.2

The interrupt-parent and interrupts = are commented out in -v5.1.dtsi
and active in -v5.2.dtsi.

Maybe the ts3a227e driver simply assumes that the interrupt is defined
and has no fallback for missing interrupt.

That it can not be requested on v5.2 board is the missing tca6424 (gpio99)
device.

BR,
Nikolaus



More information about the Letux-kernel mailing list