[Letux-kernel] [PATCH 0/2] power: generic-adc-battery: fix out of bounds write

H. Nikolaus Schaller hns at goldelico.com
Tue Jun 26 21:01:31 CEST 2018


Hi,

> Am 26.06.2018 um 20:13 schrieb Belisko Marek <marek.belisko at gmail.com>:
> 
> Hi,
> 
> those patches was already posted but was refused to merge because
> Pavel + Sebastian was talking about libbattery approach so it was not
> acceptable for them.

Well, we might start another attempt, since there is no libbattery.
IMHO, Pavel started one but nobody jumped on his train.
Or is there one now?

But I think Andreas meant a handful of patches that should fix the
gab-driver and improve DT management.

IMHO they were not happy to have the kernel calculate/estimate remaining
capacity. If that was (and is) their only concern, we should repack that
into a separate set of patches.

BR,
Nikolaus

> 
> BR,
> 
> marek
> On Tue, Jun 26, 2018 at 7:07 PM H. Nikolaus Schaller <hns at goldelico.com> wrote:
>> 
>> Hi,
>> 
>>> Am 26.06.2018 um 18:52 schrieb Andreas Kemnade <andreas at kemnade.info>:
>>> 
>>> Hi,
>>> 
>>> what about upstreaming the other simple fixes in that branch as
>>> well? At first glance some look like things which should go in without
>>> discussion.
>> 
>> Which ones would you choose?
>> 
>> Mac:master hns$ git log --oneline letux-base..work/letux-base/marek/generic-adc-battery-v2
>> 9f37066cca26 power: generic-adc-battery: Use uV and uA for voltage and current
>> 8399fac721f5 power: generic-adc-battery: fix NULL pointer dereference and provide estimate for mAh of charge
>> ec1b68114f51 power: generic-adc-battery: Fix gpio warning
>> 7c9143881c9f power: generic-fuel-gauge: Fix percentage when mV is zero
>> b157194be3da power: generic-adc-battery: silence log overflow by palmas gpadc reporting raw and not processed temperature
>> 84ec34382cc5 power: generic-fuel-gauge: Fix fuel gauge formula for negative values
>> b0484435059d power: generic-adc-battery: Fix status when we don't have notifies from core
>> f0a3906d1054 power: generic-adc-battery: Add capacity handling
>> 36fc364194b0 power: Add formula for computing LiIon State of Charge from Voltage
>> 29215fa82f21 power: generic-adc-battery: Make battery working
>> d80179f20359 power: generic-adc-battery: Add support for temperature and add check for charge from iio current channel
>> 44d8554a90a1 power: generic-adc-battery: Parse more properties from DT
>> ae28d3a1c0fc dt-bindings: power: Add battery types
>> 0d72be735b14 power: generic-adc-battery: Fix wrong status update
>> 0df4d5dc7d35 power: generic-adc-battery: check for duplicate properties copied from iio channels
>> 06e010990476 power: generic-adc-battery: fix out-of-bounds write when copying channel properties
>> iMac:master hns$
>> 
>> Maybe Marek can do that since he is the author of most of them.
>> 
>> BR,
>> Nikolaus
>> 
>>> 
>>> Regards,
>>> Andreas
>>> 
>>> On Tue, 26 Jun 2018 15:28:28 +0200
>>> "H. Nikolaus Schaller" <hns at goldelico.com> wrote:
>>> 
>>>> This patch set addresses two bugs in the gab_probe() function which are
>>>> there since the first commit in 3.7-rc1:
>>>> 
>>>> 1. there is an out of bounds write access by a miscalculated destination
>>>>  address for the memcpy()
>>>> 2. if iio channels are already represented by default properties, they
>>>>  appear as duplicates in uevent
>>>> 
>>>> 
>>>> H. Nikolaus Schaller (2):
>>>> power: generic-adc-battery: fix out-of-bounds write when copying
>>>>   channel properties
>>>> power: generic-adc-battery: check for duplicate properties copied from
>>>>   iio channels
>>>> 
>>>> drivers/power/supply/generic-adc-battery.c | 25 +++++++++++++++----------
>>>> 1 file changed, 15 insertions(+), 10 deletions(-)
>>>> 
>>> 
>>> _______________________________________________
>>> http://projects.goldelico.com/p/gta04-kernel/
>>> Letux-kernel mailing list
>>> Letux-kernel at openphoenux.org
>>> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
>> 
>> _______________________________________________
>> http://projects.goldelico.com/p/gta04-kernel/
>> Letux-kernel mailing list
>> Letux-kernel at openphoenux.org
>> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
> 
> 
> 
> -- 
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
> 
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> twitter: #opennandra
> web: http://open-nandra.com
> _______________________________________________
> http://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel at openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel



More information about the Letux-kernel mailing list