[Letux-kernel] [PATCH letux] panel-boe-w667l: hack-fix disapble oopses

Andreas Kemnade andreas at kemnade.info
Sat Dec 1 12:38:18 CET 2018


Hi,

On Sat, 1 Dec 2018 09:36:43 +0100
"H. Nikolaus Schaller" <hns at goldelico.com> wrote:

> Hi Andreas,
> 
> > Am 01.12.2018 um 09:04 schrieb Andreas Kemnade <andreas at kemnade.info>:
> > 
> > Hi,
> > 
> > panel-dsi-cm also seems not to do in->opes->disable(),
> > so maybe it should really be removed.  
> 
> Yes, that should be right.
> 
> There are two aspects:
> 1. calling in->ops->disable is (was?) needed when chaining the panel behind the ssd2258 rotator chip so that it is informed about panel disable
> 2. there was a big change in 4.20-rc1 how in and in->ops are set up and passed down to panel drivers
> 
> The panel-dsi-cm is not prepared for such encoder chaining.
> 
> So it might or might not be necessary to keep it. All this is something which I wasn't able to debug so far.
> 
> Of course we should not call in->ops->disable if in->ops == NULL :)
> 
well, being able to enable something and then not being able to disable
it is highly counter-intuitive.

Regards,
Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.goldelico.com/pipermail/letux-kernel/attachments/20181201/987d8d2b/attachment.asc>


More information about the Letux-kernel mailing list