[Letux-kernel] 4.16 onenand

H. Nikolaus Schaller hns at goldelico.com
Tue Apr 10 16:06:54 CEST 2018


Hi,

> Am 10.04.2018 um 09:56 schrieb H. Nikolaus Schaller <hns at goldelico.com>:
> 
> So let's see if I can now reduce from 48 candidates to 1...

Yeah! Did work this time :)

iMac:master hns$ git bisect log
git bisect start '--no-checkout'
# good: [d8a5b80568a9cb66810e75b182018e9edb68e8ff] Linux 4.15
git bisect good d8a5b80568a9cb66810e75b182018e9edb68e8ff
# bad: [7928b2cbe55b2a410a0f5c1f154610059c57b1b2] Linux 4.16-rc1
git bisect bad 7928b2cbe55b2a410a0f5c1f154610059c57b1b2
# bad: [dff839f27dc8d70e191562c8e78b0a9a88028362] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
git bisect bad dff839f27dc8d70e191562c8e78b0a9a88028362
# bad: [edbe69ef2c90fc86998a74b08319a01c508bd497] Revert "defer call to mem_cgroup_sk_alloc()"
git bisect bad edbe69ef2c90fc86998a74b08319a01c508bd497
# bad: [2155e69a9d9acd42488ef994a4e1ff535438c128] Merge tag 'dmaengine-4.16-rc1' of git://git.infradead.org/users/vkoul/slave-dma
git bisect bad 2155e69a9d9acd42488ef994a4e1ff535438c128
# bad: [f0b13428c95da67bbf77915e320030d9f18e7fcc] Merge branch 'x86-cache-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad f0b13428c95da67bbf77915e320030d9f18e7fcc
# bad: [47d5cc5be396eca67cc89572957ff16f10fd768e] Merge tag 'hwmon-for-linus-v4.16' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging
git bisect bad 47d5cc5be396eca67cc89572957ff16f10fd768e
# good: [c86d95cb6b7ecda7b7d56e40c24b7d8b9bf9159a] Merge tag 'asoc-v4.16-3' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-next
git bisect good c86d95cb6b7ecda7b7d56e40c24b7d8b9bf9159a
# good: [1a9a126b5098160ca934a352617e9e65dbfa679d] Merge tag 'acpi-4.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
git bisect good 1a9a126b5098160ca934a352617e9e65dbfa679d
# good: [679f50b8d1f80a7083444c5a8aa02281b9ff9cc1] hwmon: (sht21) Fix documentation of struct sht21
git bisect good 679f50b8d1f80a7083444c5a8aa02281b9ff9cc1
# good: [571e3f3a8e6582ecce2c7fd5d0a9e2ae74cece02] hwmon: (w83773g) Fix fault detection and reporting
git bisect good 571e3f3a8e6582ecce2c7fd5d0a9e2ae74cece02
# good: [ef9e1cdf419a37065364edb47bd6dd9aee1bcb7d] hwmon: (pmbus/cffps) Add led class device for power supply fault led
git bisect good ef9e1cdf419a37065364edb47bd6dd9aee1bcb7d
# bad: [0fc7e74663447682c904fe375bb680b004ddaa14] Merge tag 'mtd/for-4.16' of git://git.infradead.org/linux-mtd
git bisect bad 0fc7e74663447682c904fe375bb680b004ddaa14
# good: [bc4e118355caf83f472a5d31b850e73adddcf0ab] Merge tag 'mfd-next-4.16' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
git bisect good bc4e118355caf83f472a5d31b850e73adddcf0ab
# good: [aa5e75bc7a7c4ecbdee7bc85d1a306041b926e24] Merge tag 'for-backlight-next-4.16' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight
git bisect good aa5e75bc7a7c4ecbdee7bc85d1a306041b926e24
# good: [e6854e029b16bfd059194aabaa738d6d0d982cac] mtd: onenand: omap2: Remove regulator support
git bisect good e6854e029b16bfd059194aabaa738d6d0d982cac
# good: [c8f22b02a8bbc74525d17dd37d39bdf599e68a79] Merge tag 'spi-nor/for-4.16' of git://git.infradead.org/linux-mtd into mtd/next
git bisect good c8f22b02a8bbc74525d17dd37d39bdf599e68a79
# bad: [b4525db6f0c6dc02ad2bde08a3bcdcf0ad7891d4] MAINTAINERS: Add entry for Marvell NAND controller driver
git bisect bad b4525db6f0c6dc02ad2bde08a3bcdcf0ad7891d4
# good: [fb25070afdf07cc62282c27357dc30ef3d7ef262] mtd: onenand: omap2: Unify OMAP2 and OMAP3 DMA implementation
git bisect good fb25070afdf07cc62282c27357dc30ef3d7ef262
# bad: [bdaca9345d41fd9420995469d27603ea62054691] mtd: onenand: omap2: Decouple DMA enabling from INT pin availability
git bisect bad bdaca9345d41fd9420995469d27603ea62054691
# good: [f5229331f13b84389cd71a58ccd5e15e5cb091c2] mtd: onenand: omap2: Do not make delay for GPIO OMAP3 specific
git bisect good f5229331f13b84389cd71a58ccd5e15e5cb091c2
# first bad commit: [bdaca9345d41fd9420995469d27603ea62054691] mtd: onenand: omap2: Decouple DMA enabling from INT pin availability
iMac:master hns$ 

This commit has the following message:

commit bdaca9345d41fd9420995469d27603ea62054691
Author: Ladislav Michl <ladis at linux-mips.org>
Date:   Fri Jan 12 14:16:57 2018 +0100

    mtd: onenand: omap2: Decouple DMA enabling from INT pin availability
    
    INT pin (gpio_irq) is not really needed for DMA but only for notification
    when a command that needs wait has completed. DMA memcpy can be still used
    even without gpio_irq available, so enable it unconditionally.
    
    Signed-off-by: Ladislav Michl <ladis at linux-mips.org>
    Reviewed-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
    Tested-by: Tony Lindgren <tony at atomide.com>
    Tested-by: Aaro Koskinen <aaro.koskinen at iki.fi>
    Acked-by: Roger Quadros <rogerq at ti.com>
    Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>


This is a really hot candidate!

* OneNAND specific
* has something to do with DMA (the kernel panic I see is DMA related)
* introduced between 4.15.0 and 4.16-rc1

Hopefully we can fix that soon. And then check if the other OneNAND errors
are also gone - or do another git bisect session.

BR,
Nikolaus



More information about the Letux-kernel mailing list